elvisangelaccio abandoned this revision.
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7253#135251, @apol wrote:
> Ugh my bad ^^', I don't know what happened.
>
> > The reason why I'm discussing this is that I think one of the advantages
of Flatpak
>
> is that i
cgiboudeaux added inline comments.
INLINE COMMENTS
> KDECMakeSettings.cmake:361
> +function(_find_json_recipe json_recipe)
> +execute_process(COMMAND git ls-files *org.kde.*.json
> +OUTPUT_VARIABLE json
find_package(Git)
if(Git_FOUND)
execute_process(COMMAND GIT_EXECUTABLE...
else(
apol added a comment.
Ugh my bad ^^', I don't know what happened.
> The reason why I'm discussing this is that I think one of the advantages of
Flatpak
is that it makes it much easier to set up the build environment. Documented
dependencies and tooling that integrates it. We need to
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7253#134703, @apol wrote:
> In https://phabricator.kde.org/D7253#134653, @elvisangelaccio wrote:
>
> > Main reason is having a simple way to run flatpak-builder with the proper
arguments. Otherwise you have to copy-paste
apol added a comment.
In https://phabricator.kde.org/D7253#134653, @elvisangelaccio wrote:
> Main reason is having a simple way to run flatpak-builder with the proper
arguments. Otherwise you have to copy-paste the command from somewhere (which
could be error-prone).
> One usually alr
elvisangelaccio added a comment.
Main reason is having a simple way to run flatpak-builder with the proper
arguments. Otherwise you have to copy-paste the command from somewhere (which
could be error-prone).
One usually already has a build folder around, so the idea is you change some
code
apol added a comment.
Interesting feature.
I'm not opposed to it, but I have the feeling that it belongs to a different
layer, so this means creating a build directory to call flatpak to call cmake.
:P
Also the arguments one passes to cmake won't have any effect on the flatpak.
Wh
elvisangelaccio added reviewers: apol, Frameworks.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7253
To: elvisangelaccio, apol, #frameworks
Cc: #frameworks, #build_system
elvisangelaccio created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
If there is a `org.kde.*.json` file in the git repository of the cmake
project, we assume is a flatpak re
