Re: Review Request 129119: Fix HAVE_TRUNC cmake check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129119/ --- (Updated Oct. 19, 2016, 12:48 p.m.) Status -- This change has been marked as submitted. Review request for Build System and kdelibs. Changes --- Submitted with commit 0c642ae95dacf894e50630ffcc1961ad1e4e0322 by Albert Astals Cid to branch KDE/4.14. Repository: kdelibs Description --- On newer distros the check fails because trunc is ambiguous, so tell sizeof exactly which trunc we're speaking about. Diffs - ConfigureChecks.cmake 2729adb cmake/modules/CheckPrototypeExists.cmake 811d648 Diff: https://git.reviewboard.kde.org/r/129119/diff/ Testing --- kdelibs compiles (a bit more, there's still an unrelated issue) Thanks, Albert Astals Cid
Re: Review Request 129119: Fix HAVE_TRUNC cmake check
> On Okt. 19, 2016, 12:12 nachm., Ralf Habacker wrote: > > I had the same issue with gcc 6.2. I can confirm that the patch fixes the > > issue. I would have pushed the related commit into kdelibs repo, but got rejected with the error 'remote: Audit failure - Commit 6157880cf193c1f9f6540f768beadc844d8cff20 - Email address has an invalid domain' showing the full machine hostname. I added my email address registered by KDE into kdelibs/.git/config but still got rejected. - Ralf --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129119/#review100129 --- On Okt. 7, 2016, 11:05 nachm., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129119/ > --- > > (Updated Okt. 7, 2016, 11:05 nachm.) > > > Review request for Build System and kdelibs. > > > Repository: kdelibs > > > Description > --- > > On newer distros the check fails because trunc is ambiguous, so tell sizeof > exactly which trunc we're speaking about. > > > Diffs > - > > ConfigureChecks.cmake 2729adb > cmake/modules/CheckPrototypeExists.cmake 811d648 > > Diff: https://git.reviewboard.kde.org/r/129119/diff/ > > > Testing > --- > > kdelibs compiles (a bit more, there's still an unrelated issue) > > > Thanks, > > Albert Astals Cid > >
Re: Review Request 129119: Fix HAVE_TRUNC cmake check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129119/#review100129 --- I had the same issue with gcc 6.2. I can confirm that the patch fixes the issue. - Ralf Habacker On Okt. 7, 2016, 11:05 nachm., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129119/ > --- > > (Updated Okt. 7, 2016, 11:05 nachm.) > > > Review request for Build System and kdelibs. > > > Repository: kdelibs > > > Description > --- > > On newer distros the check fails because trunc is ambiguous, so tell sizeof > exactly which trunc we're speaking about. > > > Diffs > - > > ConfigureChecks.cmake 2729adb > cmake/modules/CheckPrototypeExists.cmake 811d648 > > Diff: https://git.reviewboard.kde.org/r/129119/diff/ > > > Testing > --- > > kdelibs compiles (a bit more, there's still an unrelated issue) > > > Thanks, > > Albert Astals Cid > >
Re: Review Request 129119: Fix HAVE_TRUNC cmake check
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129119/#review100057 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 7, 2016, 11:05 p.m., Albert Astals Cid wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129119/ > --- > > (Updated Oct. 7, 2016, 11:05 p.m.) > > > Review request for Build System and kdelibs. > > > Repository: kdelibs > > > Description > --- > > On newer distros the check fails because trunc is ambiguous, so tell sizeof > exactly which trunc we're speaking about. > > > Diffs > - > > ConfigureChecks.cmake 2729adb > cmake/modules/CheckPrototypeExists.cmake 811d648 > > Diff: https://git.reviewboard.kde.org/r/129119/diff/ > > > Testing > --- > > kdelibs compiles (a bit more, there's still an unrelated issue) > > > Thanks, > > Albert Astals Cid > >
