Re: phab reviews

2017-09-01 Thread Ben Cooksley
On Tue, Aug 29, 2017 at 8:52 PM, Harald Sitter wrote: > On Sat, Aug 26, 2017 at 10:17 PM, Ben Cooksley wrote: >> On Sun, Aug 27, 2017 at 1:15 AM, Adriaan de Groot wrote: >>> On Saturday 26 August 2017 23:06:29 Ben Cooksley wrote: > Not from

Re: phab reviews

2017-08-29 Thread Harald Sitter
On Sat, Aug 26, 2017 at 1:06 PM, Ben Cooksley wrote: >> fact we could perhaps automate this (initially on repo creation?). We >> have a members property in our repo-metdata yamls, so we could have a >> package for each repo that tracks all files and subscribes the Owners. >>

Re: phab reviews

2017-08-26 Thread Ben Cooksley
On Sun, Aug 27, 2017 at 1:15 AM, Adriaan de Groot wrote: > On Saturday 26 August 2017 23:06:29 Ben Cooksley wrote: >> > Not from `arc` which is a wholly different problem I suppose. But yes, >> > it's kinda manageable, just not all that convenient. The tricky bit is >> > really

Re: phab reviews

2017-08-26 Thread Adriaan de Groot
On Saturday 26 August 2017 23:06:29 Ben Cooksley wrote: > > Not from `arc` which is a wholly different problem I suppose. But yes, > > it's kinda manageable, just not all that convenient. The tricky bit is > > really figuring out who to set as reviewer to begin with. > > Ideally you wouldn't need

Re: phab reviews

2017-08-26 Thread Ben Cooksley
On Sat, Aug 26, 2017 at 1:11 AM, Harald Sitter wrote: > On Fri, Aug 25, 2017 at 2:00 PM, Ben Cooksley wrote: >> On Fri, Aug 25, 2017 at 8:59 PM, Harald Sitter wrote: >>> For one it makes it hard to keep on top of reviews across all our

Re: phab reviews

2017-08-25 Thread Harald Sitter
On Fri, Aug 25, 2017 at 2:00 PM, Ben Cooksley wrote: > On Fri, Aug 25, 2017 at 8:59 PM, Harald Sitter wrote: >> For one it makes it hard to keep on top of reviews across all our software. >> More importantly though, how exactly do we expect a drive-by >>

Re: phab reviews

2017-08-25 Thread Ben Cooksley
On Fri, Aug 25, 2017 at 8:59 PM, Harald Sitter wrote: > Hola! Hi Harald, > > Our phabricator guide says that at least one person needs to be set as > reviewer to get any review. > https://community.kde.org/Infrastructure/Phabricator#Posting_a_Patch > > This sucks. That is

phab reviews

2017-08-25 Thread Harald Sitter
Hola! Our phabricator guide says that at least one person needs to be set as reviewer to get any review. https://community.kde.org/Infrastructure/Phabricator#Posting_a_Patch This sucks. For one it makes it hard to keep on top of reviews across all our software. More importantly though, how