Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/ --- (Updated April 27, 2011, 7:28 a.m.) Review request for kdelibs and David

Re: Review Request: First part of fixes for password caching in KIO: SlaveBase::openPaswordDialog

2011-04-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101174/#review2915 --- This review has been submitted with commit

Re: [Kde-scm-interest] Re: libtagaro - kdereview [- kdegames]

2011-04-27 Thread Stefan Majewsky
On Fri, Apr 22, 2011 at 3:39 PM, Torgny Nyblom k...@nyblom.org wrote: +1 a module is a unit and should be treated as such even if the different apps are in different gits. So should I move the code to SVN then? This discussion was on kde-games-devel already, and the mass figured it's quite

Re: Empty merges per release

2011-04-27 Thread Oswald Buddenhagen
On Wed, Apr 27, 2011 at 09:40:08AM +0200, Thiago Macieira wrote: I know we decided to use cherry-picks to bring commits from past versions to master, but this has caused that the 4.5 and 4.6 commits are never in the past history of master. which is the state we had with svn. it was

Re: Empty merges per release

2011-04-27 Thread Thiago Macieira
Em Wednesday, 27 de April de 2011, às 12:46:40, Oswald Buddenhagen escreveu: if you want to make that git feature useful in the kde-ish cherry-pick regime, tag the stable branch points - if you want to know when a commit on a stable branch hit master, you need the extra step of following the

Re: Empty merges per release

2011-04-27 Thread Tom Albers
- Original Message - (oh well, who cares, given all that scripty crap in the history) I consider our translations very important for KDE. Would be nice if people -in general- do not consider translations and the contributors working on that as second class community members. Calling

Re: Review Request: Allow KWidgetItemDelegate::createItemWidgets to know what index corresponds to the widgets

2011-04-27 Thread Rafael Fernández López
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101219/#review2924 --- Ship it! That's a no brainer. Please, ship it. As a side

Re: Empty merges per release

2011-04-27 Thread Alexander Neundorf
On Wednesday 27 April 2011, John Layt wrote: On Wednesday 27 Apr 2011 17:52:32 Alexander Neundorf wrote: On Wednesday 27 April 2011, Thiago Macieira wrote: I know we decided to use cherry-picks to bring commits from past versions to master, Is this what is described here ?

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/#review2926 --- kioslave/ftp/ftp.cpp

Re: Chinese Lunar Calendar Support in Kdelibs

2011-04-27 Thread Liang Qi
Hi, John and Feng Huang, It's glad to see the interests on this old topic. Sorry, I forgot to update the info about relicense of ccal(at least part for chinese calendar date calculate). My change is in http://code.google.com/p/kcalendar/source/browse/trunk/README Yes, I also updated the link

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
On April 27, 2011, 7:58 p.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 605 http://git.reviewboard.kde.org/r/101173/diff/3/?file=15471#file15471line605 Oh, I thought we could remove the boolean altogether. I don't really understand the way the patch works. The

Re: Empty merges per release

2011-04-27 Thread John Layt
On Wednesday 27 Apr 2011 19:59:05 Alexander Neundorf wrote: I mean, I can help with simple things. If we agree that the following pages should be gone http://techbase.kde.org/Development/Tutorials/Git http://techbase.kde.org/Development/Tutorials/Git/Pushing

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
On April 27, 2011, 11:42 p.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 367 http://git.reviewboard.kde.org/r/101173/diff/4/?file=15510#file15510line367 Sorry, I still have a question. After a username change, setHost is going to be called, right? So it will