Re: Review Request: Do not terminate threads

2011-08-04 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5371 --- QHostInfo is already threaded. This code is unnecessary today

Re: KWallet/KSecretsService GIT workflow

2011-08-04 Thread Sebastian Kügler
Hi Valentino, On Monday, August 01, 2011 17:13:18 Valentin Rusu wrote: KSecretsService API is now nearing the finished state. But this would be confirmed by starting using it as a KWallet API backend. Naturally, I'll do this on my system but I'd like to do it such that: Very cool :-) One

Re: Formal complaint concerning the use of the name System Settings by GNOME

2011-08-04 Thread George Spelvin
I think what is needed is a series of more specific alternate names in a .desktop file, with more levels than the current GenericName and Name. By default, applications get the simplest name. If there is a collision, *both* get promoted to the next most specific name. E.g. you might have

Re: Review Request: Remove monthly auto backups from the GUI

2011-08-04 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102195/#review5374 --- Please put this in the group nepomuk. Then Vishesh will surely

Re: Review Request: Remove monthly auto backups from the GUI

2011-08-04 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102195/ --- (Updated Aug. 4, 2011, 8:56 a.m.) Review request for KDE Runtime, Nepomuk

Re: Review Request: Remove monthly auto backups from the GUI

2011-08-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102195/#review5376 --- This review has been submitted with commit

Re: Review Request: Remove monthly auto backups from the GUI

2011-08-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102195/#review5377 --- This review has been submitted with commit

Re: KWallet/KSecretsService GIT workflow

2011-08-04 Thread Valentin Rusu
Hello Sebas :-) On 08/04/2011 09:51 AM, Sebastian Kügler wrote: Hi Valentino, [snip] One more component should be the KWallet backend, an implementation of the current KWallet class based on the new Client API. KWallet code is actually spread inside several GIT repositories: kdelibs,

Re: How to get krazy check playground/ksecretservice ?

2011-08-04 Thread Valentin Rusu
On 08/01/2011 03:19 PM, Allen Winter wrote: On Sunday 31 July 2011 6:19:20 PM Valentin Rusu wrote: Hello, I'd like to get the KSecretsService code checked by Krazy. [snip] In playground/base (SVN) create a file called .krazy with the line: EXTRASUBS ksecretservice then commit

Re: Review Request: Do not terminate threads

2011-08-04 Thread Albert Astals Cid
On Aug. 4, 2011, 7:14 a.m., Thiago Macieira wrote: QHostInfo is already threaded. This code is unnecessary today and should be removed. If we remove the thread we need to introduce a nested eventloop since that method is public and supposed to be blocking. Is that OK? - Albert

Re: Review Request: new kded daemon to check .thumbnail directory space usage

2011-08-04 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/#review5389 --- it is missing the code to delete the files And I doubt we

Re: Review Request: Do not terminate threads

2011-08-04 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5390 --- Ok, then there's something wrong. QHostInfo has had a blocking

Re: Review Request: Do not terminate threads

2011-08-04 Thread Albert Astals Cid
On Aug. 4, 2011, 1:11 p.m., Thiago Macieira wrote: Ok, then there's something wrong. QHostInfo has had a blocking method since Qt 4.0. Can not use it since we have a timeout parameter. Thus we either need the thread (to use the blocking method and forget about the thread when the timeout

Fix kopete/kdenetwork build against Qt 4.8

2011-08-04 Thread Jeremy Whiting
Hello, Qt 4.8 has a change to moc which makes virtual inheritance from QObject no longer possible. This caused a problem in Jovie that was fixed by not virtually inheriting from QObject anymore. There is a similar compile problem in kdenetwork/kopete/libkopete at the moment and the attached

Re: Review Request: Do not terminate threads

2011-08-04 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5396 --- That makes sense. Then we need only one thread, one that runs

Re: Review Request: Do not terminate threads

2011-08-04 Thread Dawit A
On Thu, Aug 4, 2011 at 5:31 AM, Albert Astals Cid tsdg...@terra.es wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/ On August 4th, 2011, 3:19 a.m., *Dawit Alemayehu* wrote: I do not like this patch for the very reason you stated.

Re: Fix kopete/kdenetwork build against Qt 4.8

2011-08-04 Thread Christoph Feck
On Thursday 04 August 2011 15:46:57 Jeremy Whiting wrote: P.S. I would have used reviewboard, but there's no kdenetwork or kopete repository set up in there :) https://svn.reviewboard.kde.org/groups/

Re: Review Request: Do not terminate threads

2011-08-04 Thread Dawit A
On Thu, Aug 4, 2011 at 9:11 AM, Thiago Macieira thi...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/ Ok, then there's something wrong. QHostInfo has had a blocking method since Qt 4.0. Thiago, you must have forgotten

Re: Review Request: new kded daemon to check .thumbnail directory space usage

2011-08-04 Thread Jaime Torres Amate
On Aug. 4, 2011, 12:14 p.m., Christoph Feck wrote: it is missing the code to delete the files And I doubt we will be able to solve this. * Delete thumbnails of files that are no longer present? I have thumbnails from files of external hard disks, and I rather would like to keep

Re: RFC: replacing MacroLogFeature.cmake with FeatureSummary.cmake

2011-08-04 Thread Alexander Neundorf
On Thursday 14 July 2011, Alexander Neundorf wrote: On Thursday 14 July 2011, Sune Vuorela wrote: On Thursday 14 July 2011 03:42:01 Michael Jansen wrote: On Thursday 14 July 2011 10:49:50 Ian Wadham wrote: On 14/07/2011, at 5:16 AM, Alexander Neundorf wrote: What do you think of

Re: Dolphin Right Click Menus

2011-08-04 Thread Christoph Feck
On Friday 05 August 2011 00:09:09 Steven Sroka wrote: Does anyone know where the code is that generates the right click menu in Dolphin? Steve src/dolphincontextmenu.cpp