Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-08 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/#review5492 --- Looks like the sumilar issur in Qt:

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5499 --- - David On Aug. 7, 2011, 4:07 a.m., Dawit Alemayehu wrote:

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread David Faure
On Aug. 8, 2011, 1:53 p.m., David Faure wrote: (Sorry, flaky wifi lost the comment) I am very much against a nested event loop (QEventLoop::exec), it's a well-known fact nowadays that it creates unexpected re-entrancy and crashes. And since I just fixed the crash (missing wait() after

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-08 Thread Thomas Zander
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/#review5517 --- This change could alter the behaviour of some windows, if they

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Dawit A
On Mon, Aug 8, 2011 at 11:25 AM, Thiago Macieira thi...@kde.org wrote: On Monday, 8 de August de 2011 14:25:13 David Faure wrote: And since I just fixed the crash (missing wait() after terminate(), see commit log), I don't think we need this change. However reusing threads might be a good idea

smallish project needed

2011-08-08 Thread Lydia Pintscher
Heya folks :) I'm at the Desktop Summit and was asked by someone for a smallish project that he could hack on in KDE and that needs help. Ideally he'd like to start hacking on it tomorrow and work more on it over the next couple of days during the workshops. If you have nice ideas please let me

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Albert Astals Cid
On Aug. 8, 2011, 1:53 p.m., David Faure wrote: David Faure wrote: (Sorry, flaky wifi lost the comment) I am very much against a nested event loop (QEventLoop::exec), it's a well-known fact nowadays that it creates unexpected re-entrancy and crashes. And since I

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Thomas Zander
On Monday 08 August 2011 18.35.13 Dawit A wrote: #2. The original functions in this class were non-blocking. It is only the new function I added that is a blocking call. And that is required because of the need for a timeout when doing name lookups from the urifilter plugins. Thos plugins

Re: Review Request: Improve Calculate/Stop buttons when folder Size is being calculated

2011-08-08 Thread Kai Uwe Broulik
On Aug. 7, 2011, 11:45 a.m., Thomas Zander wrote: Hmm, did this get committed already? visually the change looks good to me, what do others think? I was in favor of just committing it as there was no feedback (: But I am 3 weeks on vacation now, so feel free to commit or I will do it

Re: Plan to transition to KDE Frameworks

2011-08-08 Thread Scott Kitterman
On Saturday, August 06, 2011 09:32:02 AM David Faure wrote: .. The next step is to backport the few bits of new api that went into master and that application developers started using, into the 4.7 branch of kdelibs. I'll work on that, but help is welcome too. ... This plan seems to be

Review Request: Use suggested filename to determine mime-type in KParts::BrowserOpenOrSave

2011-08-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102256/ --- Review request for kdelibs and David Faure. Summary --- Use the

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Dawit A
On Mon, Aug 8, 2011 at 2:31 PM, Thomas Zander zan...@kde.org wrote: On Monday 08 August 2011 18.35.13 Dawit A wrote: #2. The original functions in this class were non-blocking. It is only the new function I added that is a blocking call. And that is required because of the need for a timeout

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Thomas Zander
On Monday 08 August 2011 21.02.02 Dawit A wrote: On Mon, Aug 8, 2011 at 2:31 PM, Thomas Zander zan...@kde.org wrote: On Monday 08 August 2011 18.35.13 Dawit A wrote: #2. The original functions in this class were non-blocking. It is only the new function I added that is a blocking call. And

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Thomas Zander
On Monday 08 August 2011 21.28.45 Dawit A wrote: On Mon, Aug 8, 2011 at 3:20 PM, Thomas Zander zan...@kde.org wrote: On Monday 08 August 2011 21.02.02 Dawit A wrote: On Mon, Aug 8, 2011 at 2:31 PM, Thomas Zander zan...@kde.org wrote: On Monday 08 August 2011 18.35.13 Dawit A wrote: #2.

Review Request: Remove QObject::connect warning

2011-08-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102258/ --- Review request for kdelibs and Frederik Gladhorn. Summary --- The

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread Thiago Macieira
On Monday, 8 de August de 2011 15:28:45 Dawit A wrote: Yes. The uri filter plugins that are the primary users of this new function require a synchronous function call or they would all have to implement this syncing part individually for themselves. Then let them do it. -- Thiago Macieira -

Re: smallish project needed

2011-08-08 Thread Michael Pyne
On Monday, August 08, 2011 18:44:40 Tomaz Canabrava wrote: Juk is an easy target, and in need of love. Honestly I was going to recommend the same thing. I don't agree that it's (all) easy (although there is certainly a lot of low- hanging fruit), but it does have the advantage that I'm at least