Re: systemd and KDE (was: Re: kdeinit)

2011-08-23 Thread Aaron J. Seigo
On Sunday, August 21, 2011 17:59:33 Stefan Majewsky wrote: unit? There's an proof-of-conceptdataengine in the repo [1], but the subject is in need of someone whoknows his way around Plasma dataengines and once the unitAdded/unitRemoved signals are added to QsdManager, then those can easily be

Re: git workflow draft

2011-08-23 Thread Aaron J. Seigo
On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: Was this decided upon at some point? I got conflicting stories fromsysadmin and other developers. Yesterday after migrating kdeaccessibilityto git I was asked by a sysadmin to rename the X.Y branches to KDE/X.Y Ithink personally, i

Re: git workflow draft

2011-08-23 Thread Ben Cooksley
On Tue, Aug 23, 2011 at 6:15 PM, Aaron J. Seigo ase...@kde.org wrote: On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: Was this decided upon at some point?  I got conflicting stories fromsysadmin and other developers.  Yesterday after migrating kdeaccessibilityto git I was asked by a

Re: systemd and KDE (was: Re: kdeinit)

2011-08-23 Thread Stefan Majewsky
On Tue, Aug 23, 2011 at 8:10 AM, Aaron J. Seigo ase...@kde.org wrote: is there a way to get notified from systemd when a unit changes activation or load state? because those would also be useful in the engine, obviously. I don't see such signals, and this can be a real problem. libqsystemd

Re: systemd and KDE (was: Re: kdeinit)

2011-08-23 Thread Stefan Majewsky
On Tue, Aug 23, 2011 at 4:48 PM, Stefan Majewsky stefan.majew...@googlemail.com wrote: I don't see such signals, and this can be a real problem. Looked again, and there is a single change signal, plus a set of properties which are invalidated by this signal. Should be enough to keep the cache

Re: systemd and KDE (was: Re: kdeinit)

2011-08-23 Thread Tom Gundersen
On Tue, Aug 23, 2011 at 4:48 PM, Stefan Majewsky stefan.majew...@googlemail.com wrote: the only thing that might be interesting is to provide a serviceForSource implementation that allows interacting with a unit, if a user is able to do anything useful (such as activate/deactive a unit?). i'm

Re: git workflow draft

2011-08-23 Thread Jeremy Whiting
On Tue, Aug 23, 2011 at 12:38 AM, Ben Cooksley bcooks...@kde.org wrote: On Tue, Aug 23, 2011 at 6:15 PM, Aaron J. Seigo ase...@kde.org wrote: On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: Was this decided upon at some point? I got conflicting stories fromsysadmin and other

Review Request: Fixed rating in knewstupp3.

2011-08-23 Thread Oldřich Jedlička
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102416/ --- Review request for kdelibs. Summary --- The slot disconnection uses

Re: Review Request: Fixed rating in knewstupp3.

2011-08-23 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102416/#review5953 --- Ship it! Looks good. If you have commit access, go for it,

Re: Review Request: Fixed rating in knewstupp3.

2011-08-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102416/#review5967 --- This review has been submitted with commit

Re: git workflow draft

2011-08-23 Thread Torgny Nyblom
On Tue, 23 Aug 2011 08:15:50 +0200, Aaron J. Seigo wrote: On Monday, August 22, 2011 11:33:49 Jeremy Whiting wrote: Was this decided upon at some point? I got conflicting stories fromsysadmin and other developers. Yesterday after migrating kdeaccessibilityto git I was asked by a sysadmin to

Review Request: Do not crash when KXMLGUIFactoryPrivate::saveDefaultActionProperties' parameter contains null QActions

2011-08-23 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102419/ --- Review request for kdelibs and David Faure. Summary --- This patch