Re: Review Request: Allow externally deleted files to be removed from view in Dolphin

2011-08-25 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102435/#review6020 --- Ship it! Thanks for the patch, works nice! I've added a small u

Re: Review Request: Allow externally deleted files to be removed from view in Dolphin

2011-08-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102435/#review6019 --- This review has been submitted with commit 31b1e20348ac166b3f9a

Re: Review Request: Support GnuPG2 in KNewstuff3

2011-08-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102439/#review6018 --- This review has been submitted with commit 9eb9f85698a3c0283f8e

Re: Review Request: Support GnuPG2 in KNewstuff3

2011-08-25 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102439/#review6012 --- Ship it! Looks good, go for it. - Jeremy Paul On Aug. 25, 20

Review Request: Support GnuPG2 in KNewstuff3

2011-08-25 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102439/ --- Review request for kdelibs. Summary --- So far knewstuff has "gpg" ha

Review Request: Allow externally deleted files to be removed from view in Dolphin

2011-08-25 Thread Tirtha Chatterjee
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102435/ --- Review request for KDE Base Apps and Peter Penz. Summary --- Currentl

Re: kdeinit

2011-08-25 Thread Alex Fiestas
Something I'm going to do, and I hope that some of the metalworkers will follow is to get involved in the new platform (uStuff, NM, BlueZ...), only by winning our relevance we will be able to control the platform again. Also, I'd like to point something: In number of people I think that KDE ha

Re: Review Request: Fix KUrlCompletionPrivate::urlCompletion's behavior

2011-08-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102425/#review6007 --- This review has been submitted with commit 67b93998237a09aa2166

Re: Review Request: Fix KUrlCompletionPrivate::urlCompletion's behavior

2011-08-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102425/#review6006 --- This review has been submitted with commit e83c6f68c3d170cc0e62

Re: Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Alexander Potashev
2011/8/25 Albert Astals Cid : > The point is that usually you do not know what the library will end up doing > and by using d-pointers everywhere you make it easier for yourself to maintain > binary compatibility in the future. But in the case that most classes won't grow in the future by using my

Re: Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Albert Astals Cid
A Dijous, 25 d'agost de 2011, Alexander Potashev vàreu escriure: > 2011/8/25 Albert Astals Cid : > > I thought you were going to get rid of the private members and use a > > d-pointer instead? > > What is the point of this? I think it will be OK to keep all class > members in the main ("public") c

Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Alexander Potashev
2011/8/25 Albert Astals Cid : > I thought you were going to get rid of the private members and use a d-pointer > instead? What is the point of this? I think it will be OK to keep all class members in the main ("public") classes and use d-ptr only in case of real necessity. -- Alexander Potashev

Re: Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Albert Astals Cid
A Dijous, 25 d'agost de 2011, Alexander Potashev vàreu escriure: > 2011/8/9 Alexander Potashev : > > playground-libs/libkvkontakte moved to kdereview today. The next > > target for this project is extragear/libs. > > "libkvkontakte" has been in kdereview for more than two weeks already. > Is it OK

Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-25 Thread Alexander Potashev
2011/8/9 Alexander Potashev : > playground-libs/libkvkontakte moved to kdereview today. The next > target for this project is extragear/libs. "libkvkontakte" has been in kdereview for more than two weeks already. Is it OK to move it into extragear-libs now? -- Alexander Potashev

Re: Review Request: GSoC: Errors handling during file transfer.

2011-08-25 Thread David Faure
On Wednesday 24 August 2011 16:24:05 Cyril Oblikov wrote: > I wrote: > > But did you at least run jobtest (in kdelibs/kio/tests) to make sure > >that the new code doesn't break it? E.g. the creation of a dialog for sure > >broke it, but now you've fixed that bit. > > No, I didn't use tests. Are

Re: Dolphin Right Click Menus

2011-08-25 Thread David Faure
On Saturday 13 August 2011 00:35:10 Steven Sroka wrote: > Unfortunately not. I can see that the Create New->Link to Device is > autogenerated which is neat, but where do Create New-> > Folder.../File... etc. come from? The code in knewfilemenu.cpp reads them from the template files installed by k

Re: Review Request: Don't hang when determining MIME type of corrupted files

2011-08-25 Thread David Faure
On Monday 22 August 2011 20:12:13 Miroslav Ľos wrote: > > On Aug. 21, 2011, 10:07 a.m., David Faure wrote: > > > Thanks Peter and Miroslav. The analysis looks correct, the pre-read part > > > of the patch looks good. I'm just wondering about using Unbuffered. If > > > someone installs a mimetype de