Re: Review Request: kio_http: fix keepalive timeout parsing

2011-10-14 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102822/ --- (Updated Oct. 13, 2011, 5:59 p.m.) Review request for kdelibs, Andreas

Re: Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

2011-10-14 Thread Ralf Jung
Hi, No tabs, 4 spaces instead. http://techbase.kde.org/Policies/Kdelibs_Coding_Style Almost the complete main.cpp is using tabs currently (except for KCMUserAccount::decodeImgDrop, which uses 2 spaces) so I used it for the two lines I added. Is that okay, or am I supposed to use 4 spaces

Module layout proposal: Split kdegames-data from kdegames

2011-10-14 Thread Stefan Majewsky
[CC kde-scm-interest for notification only] [CC kde-buildsystem for feedback on the proposed build system changes] [CC kde-packagers for feedback on the implied changes to package layouts] [@CC: please keep discussion on k-c-d and k-g-d only] Moin moin, EXECUTIVE SUMMARY I propose to

Re: Module layout proposal: Split kdegames-data from kdegames

2011-10-14 Thread Alexander Neundorf
On Friday 14 October 2011, Stefan Majewsky wrote: [CC kde-scm-interest for notification only] [CC kde-buildsystem for feedback on the proposed build system changes] [CC kde-packagers for feedback on the implied changes to package layouts] [@CC: please keep discussion on k-c-d and k-g-d only]

Re: Module layout proposal: Split kdegames-data from kdegames

2011-10-14 Thread Stefan Majewsky
On Fri, Oct 14, 2011 at 9:30 PM, Alexander Neundorf neund...@kde.org wrote: IMO today with usually broadband internet access this shouldn't be much of a concern (especially if these files change only rarely). For all games, the data contributes 400 MB of uncompressable history. (I think that's

Re: Review Request: Proxy overhaul Part 6: Proxy Configuration dialog rewrite

2011-10-14 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102802/ --- (Updated Oct. 14, 2011, 8:38 p.m.) Review request for KDE Base Apps.

Re: Review Request: Improved proxy data caching in KProtocolManager

2011-10-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102840/#review7350 --- This review has been submitted with commit