Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103300/#review8638 --- Ship it! Ship It! - Sebastian Trueg On Nov. 30, 2011, 9:17

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Sebastian Trueg
On Nov. 30, 2011, 9:30 p.m., Sebastian Trueg wrote: kio/kfile/kfilemetadatareaderprocess.cpp, line 170 http://git.reviewboard.kde.org/r/103300/diff/1/?file=42530#file42530line170 Why do you need to load the kio4 catalog? Xuetian Weng wrote: Emm.. I'm not very sure for this

Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103300/ --- Review request for kdelibs and Nepomuk. Description --- The date in

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Xuetian Weng
On Nov. 30, 2011, 9:30 p.m., Sebastian Trueg wrote: kio/kfile/kfilemetadatareaderprocess.cpp, line 170 http://git.reviewboard.kde.org/r/103300/diff/1/?file=42530#file42530line170 Why do you need to load the kio4 catalog? Emm.. I'm not very sure for this part, but localization will

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Xuetian Weng
On Dec. 1, 2011, 8:40 a.m., Sebastian Trueg wrote: Ship It! Seems I can't commit to kdelibs, could you commit this? Thank you. - Xuetian --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Rolf Eike Beer
On Dec. 1, 2011, 8:40 a.m., Sebastian Trueg wrote: Ship It! Seems I can't commit to kdelibs, could you commit this? Thank you. If you have a developer account you can commit there. Maybe you just tried to commit to the locked master branch? Try committing to KDE/4.7. Eike

Re: Review Request: Fix Date Display in dolphin info panel

2011-12-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103300/#review8645 --- This review has been submitted with commit

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-12-01 Thread Andras Mantia
On Tuesday, November 29, 2011 17:29:33 Thomas =?ISO-8859-1?Q?L=FCbking?= wrote: Ok, last observation: The critical value seems to be 13 in Bespin (what means PM_ScrollBarExtent to be 15 for horizontal sliders) The value of qcommonstyle is qMax(16, QApplication::globalStrut()); FYI, this

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-12-01 Thread Thomas Lübking
On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: This fix causes a nasty regression which causes the plugin list in KRunner and other apps to be nearly unusable when compiled with gcc. Please adjust the KPluginSelector component of this fix as it must be causing a behaviour change.