Re: Review Request: Fix KCategorizedView race

2011-12-09 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8815 --- It works for me. You have my ship it. - Jaime Torres Amate

Re: kactivities update

2011-12-09 Thread Sebastian Kügler
On Thursday, December 08, 2011 17:12:05 Kevin Kofler wrote: Aaron J. Seigo wrote: yes, i skipped the details. done properly it should be linking libkactivities. this is an acceptable short term work-around given it's in a branch, while doing it right requires the modularization to be

Re: Review Request: Make the action names of KRecentFilesAction not be extremely long

2011-12-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103360/#review8822 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 8, 2011, 10:39

Re: Review Request: Make the action names of KRecentFilesAction not be extremely long

2011-12-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103360/#review8824 --- This review has been submitted with commit

Re: Review Request: Fix KCategorizedView race

2011-12-09 Thread Thomas Lübking
On Dec. 9, 2011, 8:46 a.m., Jaime Torres Amate wrote: It works for me. You have my ship it. If nobody else has a comment and since it's confirmed by Jaime and myself to be better than the current state, i'll push this 21:00 CET - so shout HOLD right now ;-) - Thomas

Re: Review Request: Fix KCategorizedView race

2011-12-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8834 --- This review has been submitted with commit

KRandomSequence and 64-bit

2011-12-09 Thread Nick Shaforostoff
Hi all. I see that KRandomSequence uses longs everywhere. long on 64-bit gcc systems is 8 bytes long, while int is always 4. maybe this is ok overall, but e.g. it uses KRandom::random() return value inside, which is int. so i suppose this can actually make the sequence less random. i propose