Re: Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

2011-12-26 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/#review9282 --- Ship it! Given that two developers have both given positive fee

Re: KDE Telepathy on its way to Extragear

2011-12-26 Thread Martin Klapetek
On Sun, Dec 25, 2011 at 22:39, Ben Cooksley wrote: > On Mon, Dec 26, 2011 at 10:26 AM, Martin Klapetek > wrote: > > Hello, > > Hi Martin, > > > > > > We're very short of releasing third version (0.3), which is also first > beta. > > We plan to introduce Nepomuk as main contact storage in the

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-26 Thread Lamarque V. Souza
Hi all, Can I submit the review below? By the way, is kdelibs still closed to pushes? Em Monday 19 December 2011, Lamarque Vieira Souza escreveu: > --- > This is an automatically generated e-mail. To reply, visit: > http://g

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

2011-12-26 Thread David Faure
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote: > > konqueror/client/kfmclient.cpp, line 386 > > > > > > The code later on uses "new KRun" for the case of a user-defined > > browser, given that KRun can handle th

Re: More devices into the Shortcut system...

2011-12-26 Thread Albert Astals Cid
El Dilluns, 26 de desembre de 2011, a les 11:31:52, Thomas Zander va escriure: > måndagen den 26 december 2011 01.36.47 skrev Albert Astals Cid: > > Ok, so after half reading the walls of text and this email what i think > > that actually what you and Rick suggest are different but not > > exclus

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

2011-12-26 Thread Dawit Alemayehu
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote: > > konqueror/client/kfmclient.cpp, line 386 > > > > > > The code later on uses "new KRun" for the case of a user-defined > > browser, given that KRun can handle th

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

2011-12-26 Thread Dawit Alemayehu
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote: > > konqueror/client/kfmclient.cpp, line 386 > > > > > > The code later on uses "new KRun" for the case of a user-defined > > browser, given that KRun can handle th

Re: Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

2011-12-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/#review9279 --- half a ship it: i think you should commit the part that fixes th

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

2011-12-26 Thread David Faure
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote: > > konqueror/client/kfmclient.cpp, line 386 > > > > > > The code later on uses "new KRun" for the case of a user-defined > > browser, given that KRun can handle th

Re: Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

2011-12-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/#review9271 --- Regarding the contrast bug, please commit it. Not sure about the

Re: More devices into the Shortcut system...

2011-12-26 Thread Thomas Zander
måndagen den 26 december 2011 01.36.47 skrev Albert Astals Cid: > Ok, so after half reading the walls of text and this email what i think > that actually what you and Rick suggest are different but not exclusive, > Rick suggests improving existing Qt classes so they can handle a few more > cases,