Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-08 Thread Rex Dieter
On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: Actually this looks more like a cmake bug, the contents of CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. What version of cmake are you using ? Felix Geyer wrote: 2.8.5 (with this commit cerry-picked:

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-08 Thread Rex Dieter
On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: Actually this looks more like a cmake bug, the contents of CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. What version of cmake are you using ? Felix Geyer wrote: 2.8.5 (with this commit cerry-picked:

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-08 Thread Alexander Neundorf
On Wednesday 08 February 2012, Rex Dieter wrote: On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: Actually this looks more like a cmake bug, the contents of CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. What version of cmake are you using ? Felix Geyer

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/#review10429 --- I don't understand, why didn't m_remoteProtocolPlugins do the

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-08 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/ --- (Updated Feb. 8, 2012, 9:56 p.m.) Review request for kdelibs. Changes

Re: Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

2012-02-08 Thread Sebastian Trueg
On Feb. 8, 2012, 8:43 p.m., David Faure wrote: I don't understand, why didn't m_remoteProtocolPlugins do the job? Because it does not include the services, only the supported protocols and mimetypes. We could merge the two - sure. I just wanted to change as little code as possible to avoid

Re: Bug in kcfg, KColorCombo not handled correct

2012-02-08 Thread Ben Cooksley
On Fri, Nov 4, 2011 at 9:50 AM, Christoph Feck christ...@maxiom.de wrote: On Thursday 03 November 2011 13:14:31 Dag Andersen wrote: Torsdag 03 november 2011 10:32:43 skrev Christoph Feck: On Thursday 03 November 2011 09:47:45 Dag Andersen wrote: AFAICS this commit:

phonon javascript

2012-02-08 Thread Shaun Reich
anyone know how can i access phonon through javascript? what lines do i import, what's the CMakeLists.txt need, and how do i access the methods/classes in javascript? looks like it's exported via Q_PROPERTY and what not, just need to know how to actually use it. -- Shaun Reich, KDE Software