Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/#review20539 --- Ship it! You were modifying a *copy* of the FtpEntry, so a

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/#review20540 --- Ship it! Well if this works, ship it. I'm confused about this

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread Ivan Čukić
On Oct. 18, 2012, 9:20 a.m., David Faure wrote: Well if this works, ship it. I'm confused about this stuff though, it only says this view has focus, but how does it get information about the current url etc? The url is set in: int KonqView::openUrl( const KUrl url, const QString

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/ --- (Updated Oct. 18, 2012, 10:13 a.m.) Review request for KDE Base Apps and

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/#review20544 --- Ship it! Ah, well, that's even better, then. (Thanks for the

Re: Review Request: Activities support for Konqueror

2012-10-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106908/#review20545 --- This review has been submitted with commit

Comparing KFileItems

2012-10-18 Thread Frank Reininghaus
Hi everyone, the operator used for comparing KFileItems is the following: bool KFileItem::operator==(const KFileItem other) const { // is this enough? return d == other.d; } Obviously, KFileItems are only considered equal if their d pointers are the same. There is a Dolphin bug where

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/#review20555 --- This review has been submitted with commit

CMake 2.8.8 will be required for kdelibs 4.10 starting October 30th

2012-10-18 Thread Alexander Neundorf
Hi, in kdelibs we require since more than 2 years cmake .2.6.4, since then many improvements and fixes have gone into cmake, and we cannot make use of them. These are e.g. * builtin automoc * support for creating proper Config.cmake files * ${CMAKE_CURRENT_LIST_DIR} and many many more. So,

Dependency Freeze for 4.10 in two weeks

2012-10-18 Thread Albert Astals Cid
Dependency freeze for 4.10 releases is in two weeks (November 1st), please be sure you update all the needed dependencies before that date. Notorious dependencies we might want to discuss: * kdelibs depends on Qt 4.7 * kde-runtime depends on kdelibs 4.8.0 * kde-baseapps depends on kdelibs

Re: Dependency Freeze for 4.10 in two weeks

2012-10-18 Thread Dawit A
Actually kde-baseapps master requires kdelibs 4.10 to work correctly. Otherwise, the new changes to the cookie settings dialog won't function properly. I posted a request asking to update the required dependency, but no one responded. See http://lists.kde.org/?l=kde-core-develm=134946200123794w=2

Re: CMake 2.8.8 will be required for kdelibs 4.10 starting October 30th

2012-10-18 Thread Michael Pyne
On Thursday, October 18, 2012 20:37:04 Alexander Neundorf wrote: Hi, in kdelibs we require since more than 2 years cmake .2.6.4, since then many improvements and fixes have gone into cmake, and we cannot make use of them. These are e.g. * builtin automoc * support for creating proper

Re: Comparing KFileItems

2012-10-18 Thread Michael Pyne
On Thursday, October 18, 2012 13:54:09 Frank Reininghaus wrote: There are ways to fix or work around this problem inside Dolphin, but I'm wondering if it makes sense to change the way KFileItems are compared. If two items do not have the same d pointers, one could check if their URLs are equal