Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-25 Thread Kevin Ottens
On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: kdeui/util/kglobalsettings.cpp, line 308 http://git.reviewboard.kde.org/r/71/diff/1/?file=165092#file165092line308 These are the colors for the window titlbar (with ambiguous function names, though), the default for

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-25 Thread Aurélien Gâteau
On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: kdeui/util/kglobalsettings.cpp, line 308 http://git.reviewboard.kde.org/r/71/diff/1/?file=165092#file165092line308 These are the colors for the window titlbar (with ambiguous function names, though), the default for

All KConfig files inherit kdeglobals keys by default, good or bad?

2013-06-25 Thread Aurélien Gâteau
[Continuing the discussion started on https://git.reviewboard.kde.org/r/71/ ] Aurélien Gâteau wrote: I see the point of having cross-app configuration files, I assume classes from kdelibs for example can use it to store settings. What I don't understand is in which

Re: All KConfig files inherit kdeglobals keys by default, good or bad?

2013-06-25 Thread Martin Gräßlin
On Tuesday 25 June 2013 10:10:03 Aurélien Gâteau wrote: Eventually the default actually should have been CascadeOnly (because IncludeGlobals seems mostly interesting to libs only). I agree, especially because I assume all the code which benefits from inheriting from kdeglobals has been

Re: All KConfig files inherit kdeglobals keys by default, good or bad?

2013-06-25 Thread Thomas Lübking
On Dienstag, 25. Juni 2013 10:10:03 CEST, Aurélien Gâteau wrote: [Continuing the discussion started on https://git.reviewboard.kde.org/r/71/ ] - kdeglobals in mind. As such, I think this code should opt-in to inherit from kdeglobals, instead of expecting all code reading

Review Request 111238: Remove iterator.end() calls from iteration loops in KDirLister

2013-06-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111238/ --- Review request for kdelibs and David Faure. Description --- The

Re: Review Request 111238: Remove iterator.end() calls from iteration loops in KDirLister

2013-06-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111238/#review35049 --- patch missing? - David Faure On June 25, 2013, 12:25 p.m.,

KF5 Update Meeting Minutes 2013-w26

2013-06-25 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 26 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, apol, ben2367, fregl, scarpino, wojtask9 and myself. Topics discussed: * Barcelona's mini-sprint was a success, should be done in sync with

Re: All KConfig files inherit kdeglobals keys by default, good or bad?

2013-06-25 Thread Aurélien Gâteau
On Tuesday 25 June 2013 14:17:16 Thomas Lübking wrote: On Dienstag, 25. Juni 2013 10:10:03 CEST, Aurélien Gâteau wrote: [Continuing the discussion started on https://git.reviewboard.kde.org/r/71/ ] - kdeglobals in mind. As such, I think this code should opt-in to inherit

Re: startkde modifies PATH to add qt4 bin dir to the front

2013-06-25 Thread Albert Astals Cid
El Dimarts, 18 de juny de 2013, a les 19:19:24, Albert Astals Cid va escriure: El Dimarts, 18 de juny de 2013, a les 09:55:23, David Faure va escriure: Le lundi 17 juin 2013 20:15:23 Albert Astals Cid a écrit : Maybe we should just make sure the qdbus calls in startkde have the full

Re: Review Request 111238: Remove iterator.end() calls from iteration loops in KDirLister

2013-06-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111238/ --- (Updated June 26, 2013, 4:44 a.m.) Review request for kdelibs and David