Fixing plasma theme removal

2013-08-02 Thread Jeremy Whiting
Hello, Today I applied and pushed a fix to make uninstalling from KNS3 for most cases work again, however https://bugs.kde.org/show_bug.cgi?id=149479 is still broken for plasma theme uninstallation and here's why: PlasmaStructure doesn't accept application/x-xz-compressed-tar format files which '

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review36990 --- This review has been submitted with commit 2f5218463d1b7b7fc6e

Re: KDirWatch bug and the analysis. Help is welcome!

2013-08-02 Thread Mark
On Fri, Aug 2, 2013 at 3:41 PM, David Faure wrote: > On Friday 02 August 2013 15:07:19 Mark wrote: >> Just for my view on this. What's the difference between stat() and >> kio::stat()? > > Err, you know the answer is in the docs, right? > stat() = unix-only, local files only, sync > KIO::stat() =

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Dawit Alemayehu
> On Aug. 2, 2013, 12:53 p.m., David Faure wrote: > > kio/kio/copyjob.cpp, line 2190 > > > > > > Where's this instance deleted? > > > > Should there be a deleteLater() in all code paths of slotResult()?

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread David Faure
> On Aug. 2, 2013, 12:53 p.m., David Faure wrote: > > kio/kio/clipboardupdater.cpp, line 108 > > > > > > The name sounds like it will clear the clipboard. > > > > removeUrlsFromClipboard would be better >

Re: KDirWatch bug and the analysis. Help is welcome!

2013-08-02 Thread David Faure
On Friday 02 August 2013 15:07:19 Mark wrote: > Just for my view on this. What's the difference between stat() and > kio::stat()? Err, you know the answer is in the docs, right? stat() = unix-only, local files only, sync KIO::stat() = portable, network-transparent, async > >> Or follow your initi

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Dawit Alemayehu
> On Aug. 2, 2013, 12:53 p.m., David Faure wrote: > > kio/kio/clipboardupdater.cpp, line 108 > > > > > > The name sounds like it will clear the clipboard. > > > > removeUrlsFromClipboard would be better

Re: KDirWatch bug and the analysis. Help is welcome!

2013-08-02 Thread Mark
On Fri, Aug 2, 2013 at 12:15 PM, David Faure wrote: > On Thursday 01 August 2013 15:06:05 Mark wrote: >> On Thu, Aug 1, 2013 at 10:41 AM, David Faure wrote: >> > On Thursday 01 August 2013 01:30:08 Mark wrote: >> >> However, we have been given the power of inotify which gives more >> >> detailed

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review36984 --- Sorry for my slow review which led you to commit meanwhile, but

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/ --- (Updated Aug. 2, 2013, 12:37 p.m.) Status -- This change has been mar

Re: Review Request 111776: Update URLs copied to clipboard when they change due to KIO operations

2013-08-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111776/#review36982 --- This review has been submitted with commit 2f19231bc9f32f2642d

Re: KDirWatch bug and the analysis. Help is welcome!

2013-08-02 Thread David Faure
On Thursday 01 August 2013 21:24:19 Rolf Eike Beer wrote: > David Faure wrote: > > On Thursday 01 August 2013 01:30:08 Mark wrote: > > > However, we have been given the power of inotify which gives more > > > detailed > > > signals and lets us know which files have been created/added/modified > > >

Re: KDirWatch bug and the analysis. Help is welcome!

2013-08-02 Thread David Faure
On Thursday 01 August 2013 15:06:05 Mark wrote: > On Thu, Aug 1, 2013 at 10:41 AM, David Faure wrote: > > On Thursday 01 August 2013 01:30:08 Mark wrote: > >> However, we have been given the power of inotify which gives more > >> detailed > >> signals and lets us know which files have been created