Re: Review Request 113366: kio_http: small optimization in response code parsing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113366/#review42146 --- Ship it! Ship It! - Dawit Alemayehu On Oct. 21, 2013, 3:23

Re: Review Request 113299: KDirWatch code style: braces for one-liner conditionals

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113299/ --- (Updated Oct. 21, 2013, 7:31 p.m.) Status -- This change has been dis

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 21, 2013, 10:30 p.m.) Status -- This change has been ma

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review42138 --- This review has been submitted with commit 11ee78a9c8139f236f3

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote: > > Have you tried a naive implementation with a > > std::vector>? You say that a typical use case has > > eight entries; that's a very small number where a well-tuned vector could > > easily beat the O(1) of QHash or the O(log n) of QMap by it

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42133 --- kio/kio/udsentry.cpp

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42128 --- Oh wow! When reading through the comments i was quite surprised

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote: > > Have you tried a naive implementation with a > > std::vector>? You say that a typical use case has > > eight entries; that's a very small number where a well-tuned vector could > > easily beat the O(1) of QHash or the O(log n) of QMap by it

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote: > > Have you tried a naive implementation with a > > std::vector>? You say that a typical use case has > > eight entries; that's a very small number where a well-tuned vector could > > easily beat the O(1) of QHash or the O(log n) of QMap by it

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote: > > kio/kio/udsentry.cpp, line 51 > > > > > > have you tried with a QMap? It has a lower memory overhead than QHash. > > And for few items (which is the case here

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/ --- (Updated Oct. 21, 2013, 6:23 p.m.) Review request for kdelibs. Changes -

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

On Monday 21 October 2013 15:25:41 Michael Pyne wrote: > > On Sept. 23, 2013, 9:12 a.m., Kevin Ottens wrote: > > > Any reason why this patch isn't committed yet? Please do so ASAP. > > > > Kevin Ottens wrote: > > Any news? > > > > I'll close it as discarded if I don't see any activity

Re: kactivities master becomes Qt5/KF5-based

> Well, to be honest, if you don't want a 4.13 release i'd prefer you actually > use master for KF5. Otherwise people might random-commit fixes to master > and then wonder why they never got into a release, so the two situations i > think make sense are: People don't really contribute to kactivit

Re: Dependency to unreleased versions

Problem already reported here : https://bugs.kde.org/show_bug.cgi?id=326368 It's completly different issue. Sound like client libraw code (as libkdcraw) need to be linked to libgomp when libraw OpenMP support is enabled. As libraw has already resolved OpenMP symbols at packaging time, why libkdcr

Re: kactivities master becomes Qt5/KF5-based

El Dilluns, 21 d'octubre de 2013, a les 18:43:20, Ivan Čukić va escriure: > > I was planning to branch master into KDE/4.12 after October 30 and > > before November 6. > > Forget about it. Decided not to create problems - I'll use the same name > for the branch as kdelibs do for the time being - f

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote: > > Have you tried a naive implementation with a > > std::vector>? You say that a typical use case has > > eight entries; that's a very small number where a well-tuned vector could > > easily beat the O(1) of QHash or the O(log n) of QMap by it

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote: > > kio/kio/udsentry.cpp, line 51 > > > > > > have you tried with a QMap? It has a lower memory overhead than QHash. > > And for few items (which is the case here

Re: kactivities master becomes Qt5/KF5-based

> I was planning to branch master into KDE/4.12 after October 30 and > before November 6. > Forget about it. Decided not to create problems - I'll use the same name for the branch as kdelibs do for the time being - frameworks :) Also it means that you don't want a 4.13.x for kactivities, right? >

Re: kactivities master becomes Qt5/KF5-based

El Dilluns, 21 d'octubre de 2013, a les 14:02:42, Ivan Čukić va escriure: > > Please no. We have a 4.12 release to make in 2 weeks and back when we did > > the 4.12 planning the only agreed repo to be freezed for 4.11 was > > kde-workspace. > > What about doing an early KDE/4.12 branch from master

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42113 --- kio/kio/udsentry.cpp

Re: Dependency to unreleased versions

El Dilluns, 21 d'octubre de 2013, a les 09:14:54, Gilles Caulier va escriure: > Fixed with this commit : > > http://commits.kde.org/libkdcraw/6c91e18cedfe5ef37d202f6d0cf4fde1a607a9a9 > > I just tested with official Libraw 0.14.7 from my Mageia Linux box, > and all digiKam & co compile fine. It mu

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42115 --- Have you tried a naive implementation with a std::vector>? You

Re: Review Request 113366: kio_http: small optimization in response code parsing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113366/#review42111 --- +1 from me, but i'd like someone else to approve, adding a git

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

> On Sept. 23, 2013, 9:12 a.m., Kevin Ottens wrote: > > Any reason why this patch isn't committed yet? Please do so ASAP. > > Kevin Ottens wrote: > Any news? > > I'll close it as discarded if I don't see any activity by next monday. I've integrated it, you don't have to worry about

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/#review42107 --- This review has been submitted with commit 88bf26e1bc2bb3ac8a3

Review Request 113366: kio_http: small optimization in response code parsing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113366/ --- Review request for kdelibs and Dawit Alemayehu. Summary (updated)

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108845/ --- (Updated Oct. 21, 2013, 3:23 p.m.) Status -- This change has been mar

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote: > > kio/kio/udsentry.cpp, line 51 > > > > > > have you tried with a QMap? It has a lower memory overhead than QHash. > > And for few items (which is the case here

Re: Review Request 113364: kio_http: fix for proxy connection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113364/ --- (Updated Oct. 21, 2013, 1:41 p.m.) Review request for kdelibs and Dawit Al

Review Request 113364: kio_http: fix for proxy connection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113364/ --- Review request for kdelibs and Dawit Alemayehu. Repository: kdelibs Desc

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: Review Request 113175: Always use an external viewer application to view files

> konqueror/dolphin can already open at least tar/(gz, bzip) and zip files directly Dolphin can only browse through local archives, remote archives will be opened in Ark. See DolphinView::openItemAsFolderUrl for more information. Emmanuel 2013/10/19 Martin Koller > On Tuesday 08 October 2013

Re: kactivities master becomes Qt5/KF5-based

> Please no. We have a 4.12 release to make in 2 weeks and back when we did > the 4.12 planning the only agreed repo to be freezed for 4.11 was > kde-workspace. What about doing an early KDE/4.12 branch from master so that the release can continue as planned, while not slowing us down for further

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review42078 --- Ship it! Ship It! - Kevin Ottens On Oct. 17, 2013, 7:53 p.m

Re: Review Request 113299: KDirWatch code style: braces for one-liner conditionals

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113299/#review42077 --- I would leave them alone for now. I think we'll revisit the top

Re: Review Request 112880: Added KColorSchemeToken class.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review42069 --- To get in this patch would benefit from being based on the fram

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: kactivities master becomes Qt5/KF5-based

> Hi all, > > Following kde-workspace (and stealing a few sentences from that > announcement), > we're planning to merge the frameworks-scratch branch of kactivities into > master later today. That means if you're building 4.x branch of Plasma > yourself from Git, you should switch to the > KD

Re: Review Request 112367: Include the icon's theme in the cache key

> On Aug. 31, 2013, 7:11 a.m., David Faure wrote: > > I disagree. Making things slow to cover a really really corner case (mixing > > kde4 and kde5), while the solution already exists (clearing the cache when > > switching icon themes), doesn't seem very sensible to me. > > > > The point is re

kactivities master becomes Qt5/KF5-based

Hi all, Following kde-workspace (and stealing a few sentences from that announcement), we're planning to merge the frameworks-scratch branch of kactivities into master later today. That means if you're building 4.x branch of Plasma yourself from Git, you should switch to the KDE/4.11 branch. Th

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

> On Sept. 23, 2013, 9:12 a.m., Kevin Ottens wrote: > > Any reason why this patch isn't committed yet? Please do so ASAP. Any news? I'll close it as discarded if I don't see any activity by next monday. - Kevin --- This is an automatic

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

> On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote: > > kio/kio/udsentry.cpp, line 51 > > > > > > have you tried with a QMap? It has a lower memory overhead than QHash. > > And for few items (which is the case here

Re: Review Request 113175: Always use an external viewer application to view files

On Saturday, October 19, 2013 17:57:17 Martin Koller wrote: > What is the advantage of having ark at all ? > konqueror/dolphin can already open at least tar/(gz, bzip) and zip files > directly and there you have all the functionality you are discussing > currently (e.g. viewing the file according t

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355/#review42058 --- coolio :) kio/kio/udsentry.cpp

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: Review Request 113342: Add support for retrying to KIO (frameworks branch)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113342/#review42054 --- Ship it! Nice. This is simpler than I thought it would be. Pl

Re: Dependency to unreleased versions

Fixed with this commit : http://commits.kde.org/libkdcraw/6c91e18cedfe5ef37d202f6d0cf4fde1a607a9a9 I just tested with official Libraw 0.14.7 from my Mageia Linux box, and all digiKam & co compile fine. It must be the same for the rest of KDE. But, as i explain in commit log, in case of Libraw ve