Re: Review Request 112848: Adding unit tests for kbuttongroup and fixing identation

2013-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112848/#review42149 --- This review has been submitted with commit

Re: Review Request 112848: Adding unit tests for kbuttongroup and fixing identation

2013-10-22 Thread Bruno Farias
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112848/ --- (Updated Oct. 22, 2013, 7:52 a.m.) Status -- This change has been

Re: Review Request 112982: copyToFile support for kio_smb

2013-10-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982/#review42150 --- This would have been easier to review if the coding style

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-22 Thread Frank Reininghaus
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote: Have you tried a naive implementation with a std::vectorstd::pairKey,Value? You say that a typical use case has eight entries; that's a very small number where a well-tuned vector could easily beat the O(1) of QHash or the O(log n) of

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-22 Thread Frank Reininghaus
On Oct. 21, 2013, 7:36 p.m., Mark Gaiser wrote: Oh wow! When reading through the comments i was quite surprised to see a question for me :) A very nice discussion btw! As for the benchmarking. It's actually already available in a testcase if you want that:

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-22 Thread Frank Reininghaus
On Oct. 21, 2013, 8:20 p.m., Milian Wolff wrote: kio/kio/udsentry.cpp, line 240 http://git.reviewboard.kde.org/r/113355/diff/2/?file=204198#file204198line240 you still check that for every uds - does it make sense for any fields besides the ones I listed in my previous comment?

Re: Dependency to unreleased versions

2013-10-22 Thread Raymond Wooninck
On Monday 21 October 2013 19:10:49 Gilles Caulier wrote: Problem already reported here : https://bugs.kde.org/show_bug.cgi?id=326368 It's completly different issue. Sound like client libraw code (as libkdcraw) need to be linked to libgomp when libraw OpenMP support is enabled. As libraw

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-22 Thread Milian Wolff
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote: Have you tried a naive implementation with a std::vectorstd::pairKey,Value? You say that a typical use case has eight entries; that's a very small number where a well-tuned vector could easily beat the O(1) of QHash or the O(log n) of

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-22 Thread Milian Wolff
On Oct. 21, 2013, 8:20 p.m., Milian Wolff wrote: kio/kio/udsentry.cpp, line 240 http://git.reviewboard.kde.org/r/113355/diff/2/?file=204198#file204198line240 you still check that for every uds - does it make sense for any fields besides the ones I listed in my previous comment?

Re: FindKDE4Internal.cmake clang c++11 -fdelayed-template-parsing

2013-10-22 Thread Mark Kretschmann
On Sat, Oct 12, 2013 at 6:46 PM, Thiago Macieira thi...@kde.org wrote: On sábado, 12 de outubro de 2013 12:42:50, Milian Wolff wrote: Hey Raphael! Thank you for working on clang support in FindKDE4Internal.cmake. Since recently though I have build issues with clang due to the -fdelayed-

Re: FindKDE4Internal.cmake clang c++11 -fdelayed-template-parsing

2013-10-22 Thread Raphael Kubo da Costa
Milian Wolff m...@milianw.de writes: Hey Raphael! Thank you for working on clang support in FindKDE4Internal.cmake. Since recently though I have build issues with clang due to the -fdelayed- template-parsing flag passed in FindKDE4Internal.cmake. A simple example such as this: #include

Re: Dependency to unreleased versions

2013-10-22 Thread Rex Dieter
Alexander Neundorf wrote: On Sunday 20 October 2013, Torgny Nyblom wrote: Hi, What is the policy of depending on unreleased libraries? And is that written down somewhere? ... IMO it's a pain to depend on unreleased versions of anything. As this seems to be semi-regular occurrence, I

KF5 Update Meeting Minutes 2013-w43

2013-10-22 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 43 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, dfaure, dMaggot, jpwhiting, mck182, PovAddict, sebas, teo, vHanda and myself. Announcement: * All new code should use qCDebug and

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-22 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review42169 --- Martin, KDE 4.11 or master (Qt5) _must_ compile under OSX. My

Re: Review Request 113366: kio_http: small optimization in response code parsing

2013-10-22 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113366/ --- (Updated Oct. 22, 2013, 8:06 p.m.) Status -- This change has been

Re: Review Request 113366: kio_http: small optimization in response code parsing

2013-10-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113366/#review42185 --- This review has been submitted with commit

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-22 Thread Alexander Richardson
On Oct. 21, 2013, 6:26 p.m., Jan Kundrát wrote: Have you tried a naive implementation with a std::vectorstd::pairKey,Value? You say that a typical use case has eight entries; that's a very small number where a well-tuned vector could easily beat the O(1) of QHash or the O(log n) of