Re: Review Request 114314: Fix traceback in Python runner plugins

2013-12-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114314/#review45249 --- This review has been submitted with commit

Re: Review Request 114314: Fix traceback in Python runner plugins

2013-12-06 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114314/ --- (Updated Dec. 6, 2013, 9:12 a.m.) Status -- This change has been

Review Request 114328: re-add customstyleelement suite to kstyle

2013-12-06 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114328/ --- Review request for kdelibs. Repository: kdelibs Description ---

Re: Review Request 114321: Fix timezone saving in System Settings - Date Time

2013-12-06 Thread Lukáš Tinkl
On Dec. 6, 2013, 1:22 a.m., Thomas Lübking wrote: kcontrol/dateandtime/helper.cpp, line 180 http://git.reviewboard.kde.org/r/114321/diff/1/?file=222931#file222931line180 What's the problem about using zic? If zic is broken (distro related?) zic should be fixed, yesno? This

Re: Review Request 114321: Fix timezone saving in System Settings - Date Time

2013-12-06 Thread Lukáš Tinkl
On Dec. 6, 2013, 12:52 a.m., Martin Klapetek wrote: Note that Debian-based systems actually do copy the file rather than symlink - main reason being that if you use a symlink and your /usr is mounted on a separate partition, anything that starts before /usr gets mounted will not have

Re: Review Request 114321: Fix timezone saving in System Settings - Date Time

2013-12-06 Thread Thomas Lübking
On Dec. 6, 2013, 12:22 a.m., Thomas Lübking wrote: kcontrol/dateandtime/helper.cpp, line 189 http://git.reviewboard.kde.org/r/114321/diff/1/?file=222931#file222931line189 assuming zic is not available and the fallback is required, this should maybe inspect the type of the present