Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- (Updated Feb. 26, 2014, 8:34 a.m.) Review request for kdelibs, Andrea

Review Request 116077: KRunner patch so it detects Iceweasel bookmarks

2014-02-26 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116077/ --- Review request for kde-workspace. Bugs: 322399

Re: Review Request 116077: KRunner patch so it detects Iceweasel bookmarks

2014-02-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116077/#review50930 --- Ship it! Patch looks sensible. Do you have a Git account at

Re: Review Request 116077: KRunner patch so it detects Iceweasel bookmarks

2014-02-26 Thread Maximiliano Curia
On Feb. 26, 2014, 1:15 p.m., Sebastian Kügler wrote: Patch looks sensible. Do you have a Git account at KDE? Hi, No, I don't have a git account, but you are the third person that ask me that, maybe I should request one. Either way, could you please commit the change? Thanks for the

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 26, 2014, 4:53 p.m.) Status -- This change has been

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review50948 --- kio/kio/job.cpp

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/#review50957 --- ... may be it's more clear what I mean in my comments by

Re: Lokalization for KDE AppStream AppData files

2014-02-26 Thread Matthias Klumpp
Quick question: Should the AppData info be merged into the application's main po file, ot should it have a app_appdata extra po file (just like .desktop files)? I also can't really test the code I write (at least not working together) (the scripty sources are a bit confusing on what gets executed

Review Request 116097: No longer use strlcpy in kstartupconfig

2014-02-26 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116097/ --- Review request for kde-workspace. Repository: kde-workspace

Re: Review Request 116097: No longer use strlcpy in kstartupconfig

2014-02-26 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116097/ --- (Updated Feb. 26, 2014, 7:11 p.m.) Review request for kde-workspace.

Re: Lokalization for KDE AppStream AppData files

2014-02-26 Thread Kevin Krammer
On Wednesday, 2014-02-26, 18:54:43, Matthias Klumpp wrote: Quick question: Should the AppData info be merged into the application's main po file, ot should it have a app_appdata extra po file (just like .desktop files)? My guess (don't take my word on it, wait for Albert's reply) is that

Re: Lokalization for KDE AppStream AppData files

2014-02-26 Thread Albert Astals Cid
El Dimecres, 26 de febrer de 2014, a les 19:45:04, Kevin Krammer va escriure: On Wednesday, 2014-02-26, 18:54:43, Matthias Klumpp wrote: Quick question: Should the AppData info be merged into the application's main po file, ot should it have a app_appdata extra po file (just like .desktop

Re: Review Request 116097: No longer use strlcpy in kstartupconfig

2014-02-26 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116097/#review50982 --- When you start poking at this code, why not kill the entire

Re: KColorEdit in extragear/graphics

2014-02-26 Thread Nicolás Alvarez
2014-02-23 11:56 GMT-03:00 Albert Astals Cid aa...@kde.org: El Diumenge, 23 de febrer de 2014, a les 15:53:44, Albert Astals Cid va escriure: El Dissabte, 22 de febrer de 2014, a les 19:13:39, Percy Camilo Triveño Aucahuasi va escriure: Hi all, the migration is complete now[1], big thanks

Re: KColorEdit in extragear/graphics

2014-02-26 Thread Ben Cooksley
On Thu, Feb 27, 2014 at 11:15 AM, Nicolás Alvarez nicolas.alva...@gmail.com wrote: 2014-02-23 11:56 GMT-03:00 Albert Astals Cid aa...@kde.org: El Diumenge, 23 de febrer de 2014, a les 15:53:44, Albert Astals Cid va escriure: El Dissabte, 22 de febrer de 2014, a les 19:13:39, Percy Camilo

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
On Feb. 26, 2014, 4:15 p.m., Andrea Iacovitti wrote: ... may be it's more clear what I mean in my comments by showing code, see http://paste.kde.org/pvzj0ppio I did many tests and didn't found issues so far No I completely understood your point. It was just that my implementation

Re: Review Request 116073: Do not use encoded URL when creating relative symlinks

2014-02-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116073/#review50995 --- This review has been submitted with commit

Re: Review Request 116017: Implement POST - POST redirection support in KIO

2014-02-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116017/ --- (Updated Feb. 27, 2014, 6:04 a.m.) Review request for kdelibs, Andrea