Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-14 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/#review55680 --- kio/kio/kdbusservicestarter.cpp

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-14 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/ --- (Updated April 14, 2014, 11:48 a.m.) Review request for kdelibs.

Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string

2014-04-14 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/#review55705 --- Looks good to me, but maybe let dfaure have a second look -

Re: Update needed to binary compatibility guide for Windows?

2014-04-14 Thread Ian Monroe
On Sun, Apr 13, 2014 at 6:36 PM, Michael Pyne mp...@kde.org wrote: If it's true, do we want to adopt a constraint on our handling of virtual functions in leaf classes based on this? IMO we shouldn't worry about ABI on Windows. And not because meh Windows, but since Microsoft breaks C++ ABI