Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-31 Thread Ian Wadham
> On July 27, 2014, 11:17 a.m., Thomas Lübking wrote: > > drkonqi/reportassistantpages_bugzilla.cpp, line 300 > > > > > > this is commented. > > > > if the test is pointless altogether (i do not know. no

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-31 Thread RJVB Bertin
> On July 27, 2014, 1:17 p.m., Thomas Lübking wrote: > > drkonqi/gdbhighlighter.cpp, line 74 > > > > > > an abort is not a crash ;-) > > > > If you hit this assert, the looked up (lineNr - 1) is somehow o

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-31 Thread Benjamin Reed
> On July 29, 2014, 3:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > RJVB Bertin wrote: > Nope. It can be set if the user has XQuartz install

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-31 Thread RJVB Bertin
> On July 29, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote: > > kinit/kinit.cpp, line 1481 > > > > > > do you need $DISPLAY in OS X? > > RJVB Bertin wrote: > Nope. It can be set if the user has XQuartz install

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-31 Thread Thomas Lübking
> On Juli 27, 2014, 11:17 vorm., Thomas Lübking wrote: > > drkonqi/gdbhighlighter.cpp, line 74 > > > > > > an abort is not a crash ;-) > > > > If you hit this assert, the looked up (lineNr - 1) is somehow

Re: Review Request 119498: Report crashes of KDE apps in Apple OS X (2) (fix drkonqi)

2014-07-31 Thread RJVB Bertin
> On July 27, 2014, 1:17 p.m., Thomas Lübking wrote: > > drkonqi/gdbhighlighter.cpp, line 74 > > > > > > an abort is not a crash ;-) > > > > If you hit this assert, the looked up (lineNr - 1) is somehow o