Re: Pushing AppStream data to KDE project's master branches

2014-08-03 Thread Alex Merry
On Sunday 03 August 2014 01:41:29 Matthias Klumpp wrote: We are speaking of a small bit of XML, which is placed in CMAKE_INSTALL_METAINFODIR (/usr/share/appdata) - so this is not a change which could break anything (in case you still don't like it, you can always git-revert, but in that case,

Re: Pushing AppStream data to KDE project's master branches

2014-08-03 Thread Matthias Klumpp
2014-08-03 12:20 GMT+02:00 Alex Merry alex.me...@kde.org: On Sunday 03 August 2014 01:41:29 Matthias Klumpp wrote: We are speaking of a small bit of XML, which is placed in CMAKE_INSTALL_METAINFODIR (/usr/share/appdata) - so this is not a change which could break anything (in case you still

Review Request 119593: Ensure there's a plastform window before restoring the window geometry

2014-08-03 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593/ --- Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš

Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-03 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-03 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: If the only issue is the open ::exec() TODO, you might trick it by calling ::winId(), then restore the size and ultimately ::exec() Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

2014-08-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593/#review63720 --- Ship it! Good catch! :) I didn't know this was possible. -

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63721 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Aug.

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-08-03 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/ --- (Updated Srp. 4, 2014, 12:49 dop.) Status -- This change has been

Re: Review Request 119593: Ensure there's a plastform window before restoring the window geometry

2014-08-03 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119593/#review63728 --- No change here, ie. it doesn't restore the window geometry.

Re: Review Request 119594: ensure there's ::windowHandle() and then restore the a file dialogs size before calling ::exec()

2014-08-03 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63726 --- No change here, ie. it doesn't restore the file dialog

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-08-03 Thread Michael Pyne
On July 27, 2014, 11:32 a.m., Thomas Lübking wrote: kdeui/util/kcrash.cpp, line 316 https://git.reviewboard.kde.org/r/119497/diff/1/?file=293441#file293441line316 is libdispatch OSX only or is it also used on FreeBSD? The question (more to Michael ;-) is whether