Hi list!
Sorry for the potentially dumb question, but I'm very new to all this ;-)
Recently, libkface has been moved from extragear to kdegraphics/libs. The
intention was to have automated releases of this library, as KPhotoAlbum now
also uses it and not only Digikam anymore.
As of today,
On Montag, 17. November 2014 00:38:03 CEST, Albert Astals Cid wrote:
El Dilluns, 17 de novembre de 2014, a les 00:33:17, Thomas Lübking va
escriure:
You do not happen to delete a bechilded member in the
destructor explicitly,
are you?
Why would this be wrong?
Nothing*
*in general, but:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
Review request for kdelibs, Alex Merry, Aleix Pol Gonzalez, David Faure,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70516
---
Looks good to me. +1
Can you look into doing this in KF5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70517
---
There's no master branch of kdelibs
- Albert Astals Cid
On
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
(Updated Nov. 17, 2014, 3:29 p.m.)
Review request for kdelibs, Alex
On Nov. 17, 2014, 3:26 p.m., Aleix Pol Gonzalez wrote:
Looks good to me. +1
Can you look into doing this in KF5 (ECM) as well?
It's not applicable since we don't define `_BSD_SOURCE` at all there. It might
even work to just remove this in KDE4 as well, but I don't want to have to test
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70519
---
Looks solid to me :-)
+1
- Matthias Klumpp
On Nov. 17,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70520
---
This silences the following compile warnings with newer GCC
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
(Updated Nov. 17, 2014, 3:48 p.m.)
Review request for kdelibs, Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/
---
(Updated Nov. 17, 2014, 3:48 p.m.)
Review request for kdelibs, Alex
Thomas,
Thanks for the pointer. I tried changing KIO::AccessManager's destructor to
this:
AccessManager::~AccessManager()
{
QObjectList childList = children();
Q_FOREACH(QObject *child, childList) {
QNetworkReply *reply = qobject_castQNetworkReply*(child);
if (reply != 0)
On Monday, November 17, 2014 02:04:51 Aleix Pol wrote:
On Mon, Nov 17, 2014 at 12:24 AM, Milian Wolff m...@milianw.de wrote:
On Sunday 16 November 2014 23:52:25 Milian Wolff wrote:
KDevelop is currently bitten hard by a bug/limitation in desktoptojson. It
does not actually understand the
On Monday 17 November 2014 18:35:51 Sebastian Kügler wrote:
On Monday, November 17, 2014 02:04:51 Aleix Pol wrote:
On Mon, Nov 17, 2014 at 12:24 AM, Milian Wolff m...@milianw.de wrote:
snip
Fine, I could add similar code to desktoptojson, but:
Since desktoptojson will be called for the
El Dilluns, 17 de novembre de 2014, a les 13:39:07, Tobias Leupold va
escriure:
Hi list!
Hi
Sorry for the potentially dumb question, but I'm very new to all this ;-)
Recently, libkface has been moved from extragear to kdegraphics/libs. The
intention was to have automated releases of this
On Sunday 16 November 2014 18:18:07 Jeremy Whiting wrote:
==22353== Address 0x1cd1b758 is not stack'd, malloc'd or (recently) free'd
This looks like the case of accessing memory from a plugin that has been
unloaded.
Note how the backtrace started from qlibraryCleanup in qlibrary.cpp, which is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121147/#review70532
---
Ship it!
Yep, after reading the feature_test_macros(7)
Ok, how can I fix the unload order then?
On Mon, Nov 17, 2014 at 12:02 PM, Thiago Macieira thi...@kde.org wrote:
On Sunday 16 November 2014 18:18:07 Jeremy Whiting wrote:
==22353== Address 0x1cd1b758 is not stack'd, malloc'd or (recently)
free'd
This looks like the case of accessing
On Monday 17 November 2014 12:07:36 Jeremy Whiting wrote:
Ok, how can I fix the unload order then?
You don't. The libraries are unloaded in alphabetical order, but I might
change that later to a QHash and then the order is arbitrary and random.
Fix the problem in a different way. If necessary,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---
Review request for kdelibs and Plasma.
Repository: plasma-desktop
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/
---
(Updated Nov. 17, 2014, 2:11 p.m.)
Review request for kdelibs and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121161/#review70542
---
attica-kde/kdeplugin/kdeplatformdependent.cpp
On nov. 17, 2014, 9:45 p.m., Thomas Lübking wrote:
attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56
https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56
is
KdePlatformDependent::~KdePlatformDependent()
{
if
On Nov. 17, 2014, 9:45 nachm., Thomas Lübking wrote:
attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56
https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56
is
KdePlatformDependent::~KdePlatformDependent()
{
if
On Nov. 17, 2014, 2:45 p.m., Thomas Lübking wrote:
attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56
https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56
is
KdePlatformDependent::~KdePlatformDependent()
{
if
25 matches
Mail list logo
