Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

> On Nov. 28, 2014, 11:09 p.m., Pino Toscano wrote: > > drkonqi/backtracegenerator.cpp, lines 97-100 > > > > > > Shouldn't this rather be some attribute in the rc file, instead of > > hardcoding the lldb behaviou

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121286/ --- (Updated Nov. 29, 2014, 1:26 a.m.) Review request for KDE Software on Mac

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

> On Nov. 29, 2014, 12:09 a.m., Pino Toscano wrote: > > drkonqi/backtracegenerator.cpp, lines 97-100 > > > > > > Shouldn't this rather be some attribute in the rc file, instead of > > hardcoding the lldb behaviou

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121286/#review71066 --- Please remove the translations from the lldbrc files; scripty

Review Request 121286: Adding support for lldb in DrKonqi (step 1)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121286/ --- Review request for KDE Software on Mac OS X and KDE Runtime. Repository:

Re: Re: Review Request for KDecoration

On Friday 28 November 2014 15:25:03 Thomas Lübking wrote: > On Freitag, 28. November 2014 14:55:43 CEST, Martin Gräßlin wrote: > > Both signals are now removed. Works like a charm with the > > handling directly in KWin. > > I foresee trouble/complicfication on this (at least limitation) > > Assum

Re: Review Request for KDecoration

On Freitag, 28. November 2014 14:55:43 CEST, Martin Gräßlin wrote: Both signals are now removed. Works like a charm with the handling directly in KWin. I foresee trouble/complicfication on this (at least limitation) Assume a decoration wants to alter the current tab on wheel, depending on the

Re: Re: Review Request for KDecoration

On Friday 28 November 2014 12:52:44 Christoph Feck wrote: > > > > Q_PROPERTY(QFont font > > > > > > When I want to compute pixel sizes for the requested font, how > > > do I get the correct QPaintDevice needed for the QFontMetrics? > > > Otherwise, please provide a QFontMetrics (see QStyleOption).

Re: Re: Re: Review Request for KDecoration

Martin GräßlinOn Friday 28 November 2014 12:00:43 wrote: > > >void titleBarDoubleClicked(); > > > > Maybe it might sense to have the event here, to check keyboard > > modifiers? > > > > >void titleBarWheelEvent(const QPoint &angleDelta); > > > > Why not simply pass the QWheelEvent? I mi

Re: Review Request for KDecoration

On Friday, November 28, 2014 14:16:38 Martin Gräßlin wrote: > On Friday 28 November 2014 13:53:07 Sebastian Kügler wrote: > > On Friday, November 28, 2014 12:00:43 Martin Gräßlin wrote: > > > > > > The documentation is copied from Plasma. I don't know anything about > > > high > > > DPI, so maybe

Re: Re: Review Request for KDecoration

On Friday 28 November 2014 13:53:07 Sebastian Kügler wrote: > On Friday, November 28, 2014 12:00:43 Martin Gräßlin wrote: > > > Given that you call it "fundamental", I suggest to allow qreal here. > > > A "millimeter" is really small, and if you only allow integer values, > > > the precision might

Re: Review Request for KDecoration

On Friday, November 28, 2014 12:00:43 Martin Gräßlin wrote: > > Given that you call it "fundamental", I suggest to allow qreal here. > > A "millimeter" is really small, and if you only allow integer values, > > the precision might be too coarse. > > The documentation is copied from Plasma. I don't

Re: Review Request for KDecoration

On Friday 28 November 2014 12:00:43 Martin Gräßlin wrote: > On Sunday 16 November 2014 23:30:35 Christoph Feck wrote: > > On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote: > > > today I want to start the review process for the new > > > KDecoration > > > > Hi Martin, > > > > thanks for the

Re: Re: Review Request for KDecoration

On Sunday 16 November 2014 23:30:35 Christoph Feck wrote: > On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote: > > today I want to start the review process for the new KDecoration > > Hi Martin, > > thanks for the work, here are some random comments from my side. I > hope I am not too late.