Re: Apps 14.12 release aftermath / Running KF5 apps in KDE 4

2015-01-26 Thread Albert Astals Cid
El Dilluns, 26 de gener de 2015, a les 11:13:57, Jeremy Whiting va escriure: Eike, Thanks for looking into this and notifying us also. I heard some vague reports but nothing concrete like this. On Mon, Jan 26, 2015 at 8:58 AM, Eike Hein h...@kde.org wrote: Hi, it's becoming

Apps 14.12 release aftermath / Running KF5 apps in KDE 4

2015-01-26 Thread Eike Hein
Hi, it's becoming increasingly clear from feedback that we didn't think the decision to ship KF5 apps in 14.12 through very well. Distros are currently rolling it out as an upgrade to KDE 4 systems over the last 4.x apps, and users are running into the following problems: * KF5-based apps

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Thomas Lübking
On Jan. 21, 2015, 10:10 vorm., Dominik Haumann wrote: processcore/process.h, line 40 https://git.reviewboard.kde.org/r/121831/diff/3/?file=343193#file343193line40 Is virtual needed here? Gregor Mi wrote: Does it hurt here to have it virtual? I thought, if in doubt 'virtual'

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Thomas Lübking
On Jan. 21, 2015, 10:10 vorm., Dominik Haumann wrote: processcore/process.h, line 40 https://git.reviewboard.kde.org/r/121831/diff/3/?file=343193#file343193line40 Is virtual needed here? Gregor Mi wrote: Does it hurt here to have it virtual? I thought, if in doubt 'virtual'

Re: Feature matrix for future infrastructure

2015-01-26 Thread Thomas Lübking
On Montag, 26. Januar 2015 01:38:54 CET, Kevin Kofler wrote: Thomas Lübking wrote: If you had followed the discussion or at least looked at that feature matrix Milian started and that you liked to high-handedly deem as rubbish, you'd have noticed that webfrontends to upload patches (like

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Dominik Haumann
On Jan. 21, 2015, 10:10 vorm., Dominik Haumann wrote: processcore/process.h, line 40 https://git.reviewboard.kde.org/r/121831/diff/3/?file=343193#file343193line40 Is virtual needed here? Gregor Mi wrote: Does it hurt here to have it virtual? I thought, if in doubt 'virtual'

Re: libkgeomap

2015-01-26 Thread Pino Toscano
Hi, sorry for chiming in late. On Sunday 14 December 2014 18:57:44 Tobias Leupold wrote: recently, I requested to move libkface from extragear/libs to to kdegraphics/libs, because KPhotoAlbum began to use it as the first non-Digikam program. This has been done in the meantime and now, we

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Thomas Lübking
On Jan. 21, 2015, 10:10 vorm., Dominik Haumann wrote: processcore/process.h, line 40 https://git.reviewboard.kde.org/r/121831/diff/3/?file=343193#file343193line40 Is virtual needed here? Gregor Mi wrote: Does it hurt here to have it virtual? I thought, if in doubt 'virtual'

Re: Apps 14.12 release aftermath / Running KF5 apps in KDE 4

2015-01-26 Thread Jeremy Whiting
Eike, Thanks for looking into this and notifying us also. I heard some vague reports but nothing concrete like this. On Mon, Jan 26, 2015 at 8:58 AM, Eike Hein h...@kde.org wrote: Hi, it's becoming increasingly clear from feedback that we didn't think the decision to ship KF5 apps in 14.12

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-26 Thread Gregor Mi
On Jan. 26, 2015, 7:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Dominik Haumann
On Jan. 21, 2015, 10:10 vorm., Dominik Haumann wrote: processcore/process.h, line 40 https://git.reviewboard.kde.org/r/121831/diff/3/?file=343193#file343193line40 Is virtual needed here? Gregor Mi wrote: Does it hurt here to have it virtual? I thought, if in doubt 'virtual'

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-26 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122252/#review74753 --- Looks reasonable to me. I'll apply the patch locally and test

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-26 Thread Thomas Lübking
On Jan. 26, 2015, 7:05 vorm., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: libkgeomap

2015-01-26 Thread Pino Toscano
Hi, sorry for chiming in late. On Sunday 14 December 2014 18:57:44 Tobias Leupold wrote: recently, I requested to move libkface from extragear/libs to to kdegraphics/libs, because KPhotoAlbum began to use it as the first non-Digikam program. This has been done in the meantime and now, we

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74800 --- googling for KDE_MULTIHEAD revealed the real world use case

Re: Sysadmin report on the modernization of our infrastructure

2015-01-26 Thread Thomas Lübking
On Samstag, 24. Januar 2015 15:24:28 CET, Thomas Friedrichsmeier wrote: But beyond review functionality, I think moving towards a more integrated solution is clearly a step in the right direction, and this is what makes the choice of Phabricator over Gerrit a clear case to me. I assume we all

Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/ --- Review request for kde-workspace, Aleix Pol Gonzalez, Martin Gräßlin, and

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-26 Thread Martin Gräßlin
On Jan. 26, 2015, 8:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122270: port kcminit away from kdelibs4support

2015-01-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122270/#review74806 --- startkde/kcminit/main.cpp

Re: Review Request 122267: ki18n: Make it build with msvc compilers again

2015-01-26 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122267/#review74809 --- Ship it! Ship It! - Cristian Oneț On Jan. 27, 2015, 12:55

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Gregor Mi
On Jan. 21, 2015, 10:10 a.m., Dominik Haumann wrote: processcore/process.h, line 40 https://git.reviewboard.kde.org/r/121831/diff/3/?file=343193#file343193line40 Is virtual needed here? Does it hurt here to have it virtual? I thought, if in doubt 'virtual' should be used. On

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Gregor Mi
On Jan. 25, 2015, 5:28 p.m., Alex Richardson wrote: processui/scripting.h, line 74 https://git.reviewboard.kde.org/r/121831/diff/5/?file=344700#file344700line74 Isn't just changing the PROPERTY macro enough? Or is it used in some other file? Gregor Mi wrote: I did the

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 25, 2015, 10:20 p.m.) Review request for KDE Base Apps,

Re: libkgeomap

2015-01-26 Thread Albert Astals Cid
El Dijous, 1 de gener de 2015, a les 23:40:21, Albert Astals Cid va escriure: El Dijous, 1 de gener de 2015, a les 23:23:16, Gilles Caulier va escriure: 2015-01-01 23:16 GMT+01:00 Albert Astals Cid aa...@kde.org: El Diumenge, 21 de desembre de 2014, a les 19:39:27, Tobias Leupold va

Re: Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-26 Thread David Faure
On Jan. 25, 2015, 10:11 p.m., Milian Wolff wrote: kdeui/tests/krecursivefilterproxymodeltest.cpp, line 26 https://git.reviewboard.kde.org/r/17/diff/1/?file=344391#file344391line26 is this still required in qt5? this should really be added upstream, imo... I don't see this

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 25, 2015, 10:27 p.m.) Review request for KDE Base Apps,

Re: Feature matrix for future infrastructure

2015-01-26 Thread Kevin Kofler
Thomas Lübking wrote: If you had followed the discussion or at least looked at that feature matrix Milian started and that you liked to high-handedly deem as rubbish, you'd have noticed that webfrontends to upload patches (like suggested https://tools.wmflabs.org/gerrit-patch-uploader/) are

Re: Review Request 121831: libksysguard: process.h: encapsulate private fields

2015-01-26 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/ --- (Updated Jan. 25, 2015, 10:08 p.m.) Review request for KDE Base Apps,

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-26 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122252/#review74727 --- Ship it! some nitpicks, but otherwise looks good to me, esp.

Re: Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-26 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/17/#review74725 --- Ship it! Looking at the code, I can't see anything obvious,

Re: Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-26 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/17/#review74744 --- Ship it! I tested this over the weekend. It fixes the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-26 Thread Martin Gräßlin
On Jan. 26, 2015, 8:05 a.m., Martin Gräßlin wrote: My opinion is that this is a feature which should not be exposed in libksysguard. It actually ties libksysguard to KWin, while libksysguard was in the past also used in e.g. kdevelop. If libksysguard wants to offer the

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-01-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/#review74740 --- My opinion is that this is a feature which should not be

Re: Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/17/ --- (Updated Jan. 26, 2015, 8:16 a.m.) Status -- This change has been

Review Request 122267: ki18n: Make it build with msvc compilers again

2015-01-26 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122267/ --- Review request for kdelibs and Nicolás Alvarez. Repository: ki18n

Re: Review Request 122267: ki18n: Make it build with msvc compilers again

2015-01-26 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122267/ --- (Updated Jan. 26, 2015, 5:55 p.m.) Review request for kdelibs, kdewin

Re: Review Request 122268: emerge: Update mysql and ruby dependencies

2015-01-26 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122268/ --- (Updated Jan. 26, 2015, 5:54 p.m.) Review request for kdelibs, kdewin,