Re: [KDE/Mac] Multiplatform frameworks

2015-03-01 Thread René J . V . Bertin
On February 28, 2015 1:20:27 PM CET, Jeremy Whiting jpwhit...@kde.org wrote: Then data will all be under ~/Library/Application Support/Qt5/appname ? I think Ian's idea was not to use the appname bit (for stuff shared with other apps). that's a bit cleaner, but why would Qt/KDE applications

Re: Multiplatform frameworks

2015-03-01 Thread Alex Merry
On Friday 27 February 2015 22:55:18 Alex Merry wrote: On Friday 27 February 2015 13:29:59 Jeremy Whiting wrote: On Fri, Feb 27, 2015 at 4:05 AM, Alex Merry alex.me...@kde.org wrote: 4. Use the PATH_VARS to ecm_configure_package_config_file(). ecm_configure_package_config_file()

Re: [KDE/Mac] Multiplatform frameworks

2015-03-01 Thread René J . V . Bertin
On Saturday February 28 2015 18:12:40 Ian Wadham wrote: One problem is that these are NOT exactly like ~/.local/share, /usr/local/share, ~/.local/share/APPNAME and /usr/local/share/APPNAME on Linux. ... A bundle identifier is something like org.kde.appname. Actually, on my system I find:

Re: [KDE/Mac] Multiplatform frameworks

2015-03-01 Thread René J . V . Bertin
On Saturday February 28 2015 22:00:07 Ian Wadham wrote: Hi Ian, Esprit d'escalier. We could change GenericDataDir in QStandardPaths to be: ~/Library/Application Support/Qt5, /Library/Application Support/Qt5 That would work for ALL applications that use Qt5 and QSP, regardless of

Re: [KDE/Mac] Multiplatform frameworks

2015-03-01 Thread Ian Wadham
Hi Jeremy, My apologies for going back to basics. Some things you said earlier made me think we are not on the same page, but I now see that we are. On 02/03/2015, at 3:15 AM, Jeremy Whiting wrote: The example code you've given does already use prefixes. I'll explain below. On Sat, Feb

Re: [KDE/Mac] Multiplatform frameworks

2015-03-01 Thread Ian Wadham
Hi René, On 01/03/2015, at 8:17 PM, René J.V. Bertin wrote: On Sunday March 01 2015 17:37:35 Ian Wadham wrote: Let me kick off by saying that I am not necessarily in favour of doing what the Romans do… ;-) Heh, I got that! :) Yeah, but I am keeping an open mind… And I do not like

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Yichao Yu
On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Marko Käning
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Yichao Yu
On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Yichao Yu
On 十二月 8, 2014, 9:07 a.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread Marko Käning
On Dec. 8, 2014, 3:07 p.m., Martin Gräßlin wrote: this is wrong - please have a look at various frameworks on how to do it properly. In the end it should be: #if HAVE_X11 // x11 specific stuff #endif obviously it also needs a runtime check: if (QX11Info::isPlatformX11())

Re: Review Request 121390: make Qt5 theme build on Linux again

2015-03-01 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121390/ --- (Updated March 1, 2015, 10:02 p.m.) Status -- This change has been