On März 17, 2015, 1:07 nachm., Laurent Montel wrote:
src/plugins/hunspell/hunspellclient.cpp, line 27
https://git.reviewboard.kde.org/r/122987/diff/3/?file=355372#file355372line27
#include ...
we use local file.
No, the file is in an include path, not in the same directory as
Hi,
I, and Inge Wallin ( CC'ed in this email ),
have been working on a project on moving
the editor of parley into libkeduvocdocument.
For that we have moved the model classes of
parley's editor into keduvoc, and used them in
the entire codebase of parley instead of the
old model classes.
But on
On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote:
src/plugins/hunspell/CMakeLists.txt, line 7
https://git.reviewboard.kde.org/r/122987/diff/4/?file=355374#file355374line7
So you change an hardcoded path by a user chosen hardcoded one ?
looking at
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77617
---
src/plugins/hunspell/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77622
---
(not entitled to give a ship it, but) have you checked if
On March 17, 2015, 1:41 p.m., Luigi Toscano wrote:
(not entitled to give a ship it, but) have you checked if this is still
relevant for the Sonnet framework?
Ups, this review is for sonnet; I was confused by the group (please use
kdeframeworks instead of kdelibs for Frameworks-related
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
Review request for kdelibs.
Repository: sonnet
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Березень 17, 2015, 1:22 після полудня)
Review request for
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Березень 17, 2015, 1:50 після полудня)
Review request for KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Березень 17, 2015, 2:09 після полудня)
Review request for KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77636
---
Ok for me.
Just wait that maintainer gives you a Ship it
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77631
---
I am not maintainer of this module but I can put a +1
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77630
---
src/plugins/hunspell/hunspellclient.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/
---
(Updated Березень 17, 2015, 2:05 після полудня)
Review request for KDE
On Березень 17, 2015, 1:41 після полудня, Luigi Toscano wrote:
(not entitled to give a ship it, but) have you checked if this is still
relevant for the Sonnet framework?
Luigi Toscano wrote:
Ups, this review is for sonnet; I was confused by the group (please use
kdeframeworks
On March 17, 2015, 4:38 p.m., David Faure wrote:
Ship It!
Yes, both in kdelibs 4 and in the kio framework.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review77642
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review77642
---
Ship it!
Ship It!
- David Faure
On March 17, 2015, 4:17
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122987/#review77647
---
src/plugins/hunspell/CMakeLists.txt
18 matches
Mail list logo
