Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125613/#review87048 --- Thanks for the investigation and patch. kio/kio/copyjob.cpp

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

2015-10-19 Thread David Faure
On Saturday 17 October 2015 17:53:25 Alexander Potashev wrote: > Hi David, > > 2015-09-28 23:21 GMT+03:00 David Faure : > > Naming: "experimental" sounds like "it will be a framework at some point, > > when it > > stabilizes". Maybe we should say "internal" instead [was: either],

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread David Faure
> On Oct. 19, 2015, 7:28 a.m., David Faure wrote: > > kio/kio/job.cpp, line 2671 > > > > > > Same question here. As the comment says, "the result is still OK", > > which is why I didn't set an error code here.

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread Alberto Jiménez Ruiz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125613/ --- (Updated Oct. 19, 2015, 9:43 a.m.) Review request for kdelibs, Albert

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread Alberto Jiménez Ruiz
> On Oct. 19, 2015, 7:28 a.m., David Faure wrote: > > kio/kio/job.cpp, line 2671 > > > > > > Same question here. As the comment says, "the result is still OK", > > which is why I didn't set an error code here.

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread Alberto Jiménez Ruiz
> On Oct. 19, 2015, 7:28 a.m., David Faure wrote: > > kio/kio/job.cpp, line 2671 > > > > > > Same question here. As the comment says, "the result is still OK", > > which is why I didn't set an error code here.

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-10-19 Thread Jeremy Whiting
Ok, I just removed ksnapshot from the release-tools script. It won't be included in Applications 15.12 releases. On Sun, Oct 18, 2015 at 8:46 AM, Ivan Čukić wrote: >> Oh yes, I had completely forgotten about that. Thank you so much for >> bringing this to notice, Ivan! > > No

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-10-19 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review87098 --- May as well drop this now, it's largely superceded by code in