Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX
> On fév. 5, 2017, 10:07 après-midi, Dominik Haumann wrote: > > Looks good to me, would be nice to have another review by plasma > > developers. Can you commit yourself? > > > > Btw, this is unrelated, but maybe you are motivated to look into the bug > > list of the System Load Viewer applet:

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102422 --- Ship it! Looks good to me, would be nice to have another

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX
> On fév. 5, 2017, 2:52 après-midi, Dominik Haumann wrote: > > Essentially, the idea is good I think. Just tested this patch, and what I > > get looks like this: https://ibin.co/3BLqYW18K8p4.png > > In the "Compact Bar" mode, there are two bars for the cache monitors, and > > the right one

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- (Updated fév. 5, 2017, 7:11 après-midi) Review request for kde-workspace

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/#review102413 --- Essentially, the idea is good I think. Just tested this