Re: libqaccessibilityclient now in kdereview

2017-08-03 Thread Christoph Feck
On 25.07.2017 13:25, Jonathan Riddell wrote: libqaccessibilityclient is now in kdereview. The autotests need Qt5Test, but if the dependency is not installed, building fails silently. Either require Qt5Test, or make the tests optional if Qt5Test was not found. Issue found by Fabian from

Re: hanging in kdialog

2017-08-03 Thread Jos van den Oever
This issue is showing up for other users too: https://bugs.kde.org/show_bug.cgi?id=381693 https://bbs.archlinux.org/viewtopic.php?id=227681 https://www.reddit.com/r/kde/comments/6nqlul/ konsole_hangs_when_nothing_is_listening_on/

Re: Elisa is in kdereview

2017-08-03 Thread Matthieu Gallien
Hello, On samedi 29 juillet 2017 11:47:03 CEST Albert Astals Cid wrote: > El dilluns, 17 de juliol de 2017, a les 11:22:15 CEST, Matthieu Gallien va > > escriure: > > Hello, [...] > > > > I am still working on improving those lacking areas. I am currently > > integrating KConfig for

Re: hanging in kdialog

2017-08-03 Thread Jos van den Oever
Op zondag 30 juli 2017 10:25:39 CEST schreef u: > There's a review requests from me on KNotification that fixes this. Which one is that? I know dvratil submitted one to fix a timeout issue that makes knotifications think it is connected to a notifications service when it is not. The issue I'm

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated Aug. 3, 2017, 1:25 p.m.) Review request for KDE Base Apps,

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Kevin Funk
> On July 31, 2017, 9:11 a.m., Kevin Funk wrote: > > processui/ksysguardprocesslist.cpp, line 354 > > > > > > Why this? > > Gregor Mi wrote: > When I try to capture "d", then I get the following compiler

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128854/ --- (Updated Aug. 3, 2017, 11:08 a.m.) Review request for KDE Base Apps,

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
> On July 31, 2017, 9:11 a.m., Kevin Funk wrote: > > processui/ksysguardprocesslist.cpp, line 354 > > > > > > Why this? When I try to capture "d", then I get the following compiler error:

Re: Review Request 128854: Add a Tools button above the process list of System Monitor

2017-08-03 Thread Gregor Mi
> On July 31, 2017, 9:11 a.m., Kevin Funk wrote: > > CMakeLists.txt, line 21 > > > > > > libksysguard should not require Plasma, it should stay optional at best. > > > > See one line below in that