plasma-nano and plasma-phone-components are now in kdereview

2019-11-07 Thread Bhushan Shah
Hello! plasma-nano: https://invent.kde.org/kde/plasma-nano plasma-phone-components: https://invent.kde.org/kde/plasma-phone-components Two repos have been moved to kdereview, with final intended destinition being kde/workspace. plasma-nano is a minimal shell package which other shell package can

Re: KTrip in kdereview

2019-11-07 Thread Albert Astals Cid
El dimecres, 30 d’octubre de 2019, a les 14:52:29 CET, Nicolas Fella va escriure: > On Dienstag, 29. Oktober 2019 23:25:44 CET Albert Astals Cid wrote: > > El diumenge, 27 d’octubre de 2019, a les 15:29:10 CET, Nicolas Fella va > escriure: > > You're not calling > > KLocalizedString::setApplica

Re: KIOFuse in kdereview

2019-11-07 Thread Albert Astals Cid
El dimarts, 5 de novembre de 2019, a les 18:56:25 CET, David Edmundson va escriure: > As a note for reviewers, there are some /very significant/ patches > that are in the merge requests section of that repo. One should review > kio-fuse assuming those are applied. Then get these landed and ask fo

Re: KIOFuse in kdereview

2019-11-07 Thread Alexander Saoutkin
On Thu, 7 Nov 2019 at 16:34, Jonathan Riddell wrote: > This compiles for me but there's no install rule so nothing gets > installed,my ioslaves are unfused > > Jonathan > > Yes, there is no install rule. This doesn't inhibit from using KIOFuse as described in the README. Also note that https://in

Re: KIOFuse in kdereview

2019-11-07 Thread Jonathan Riddell
This compiles for me but there's no install rule so nothing gets installed,my ioslaves are unfused Jonathan

Re: Quick Charts in KDE Review

2019-11-07 Thread Friedrich W. H. Kossebau
Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic name which only asks for being misunderstood, is h

Re: Quick Charts in KDE Review

2019-11-07 Thread David Edmundson
Approved in general, but we will cover that and any ported applets effectively ported from KDeclarative::Plotter in relevant separate review processes. David

Re: Quick Charts in KDE Review

2019-11-07 Thread Alexander Potashev
чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : > > On 21-10-2019 15:22, Arjen Hiemstra wrote: > > Hi, > > > > Quick Charts has been moved to KDE review. The intent is to make it a > > Tier 1 framework. > > > > Quick Charts is a QML module that implements a set of > > high-performance, GPU accelerate