Re: Croutons in kdereview

2021-08-29 Thread Ben Cooksley
On Mon, Aug 30, 2021 at 10:00 AM Albert Astals Cid wrote: > El diumenge, 29 d’agost de 2021, a les 23:30:23 (CEST), Janet Blackquill > va escriure: > > They're there for the CamelCase headers generating macro, which > > doesn't seem to understand snake_case.h headers. > > Have you tried fixing

Re: Croutons in kdereview

2021-08-29 Thread Albert Astals Cid
El diumenge, 29 d’agost de 2021, a les 23:30:23 (CEST), Janet Blackquill va escriure: > They're there for the CamelCase headers generating macro, which > doesn't seem to understand snake_case.h headers. Have you tried fixing that in ECM? Do git+symlinks even work on windows? Or we don't care

Re: Croutons in kdereview

2021-08-29 Thread Albert Astals Cid
El diumenge, 29 d’agost de 2021, a les 5:10:04 (CEST), Janet Blackquill va escriure: > Hello, > > https://invent.kde.org/libraries/croutons is in kdereview now > > Croutons is a library containing assorted functionality for dealing > with asynchronous code in Qt, most notably a future type that

Re: Croutons in kdereview

2021-08-29 Thread Ivan Čukić
Hi, Cool to have a library like this. I have a few nit-picks. I'd put the whole library in a namespace as it uses some quite common names like Result, Error and Future. future.h:15 The Result type could be made more API-compatible with the expected std::expected. Things like explicit

Croutons in kdereview

2021-08-29 Thread Janet Blackquill
Hello, https://invent.kde.org/libraries/croutons is in kdereview now Croutons is a library containing assorted functionality for dealing with asynchronous code in Qt, most notably a future type that can be passed into QML as a JavaScript Thennable (similarly to Qt IVI's PendingReply) and headers