Re: KSvg in kdereview

2023-06-21 Thread Nate Graham
FWIW the code itself is almost entirely just moved verbatim from plasma-framework, which is already a framework. Nate On 6/21/23 12:41, Friedrich W. H. Kossebau wrote: Am Mittwoch, 21. Juni 2023, 12:23:55 CEST schrieb Ben Cooksley: On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter wrote:

Re: KSvg in kdereview

2023-06-21 Thread Friedrich W. H. Kossebau
Am Mittwoch, 21. Juni 2023, 12:23:55 CEST schrieb Ben Cooksley: > On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter wrote: > > LGTM now +2 > > > > On Wed, Jun 21, 2023 at 10:04 AM Marco Martin wrote: > > > I fixed CI, passes now > > Thanks for correcting that. > > As Friedrich raised the initial

Re: KSvg in kdereview

2023-06-21 Thread Ben Cooksley
On Wed, Jun 21, 2023 at 10:12 PM Harald Sitter wrote: > LGTM now +2 > > On Wed, Jun 21, 2023 at 10:04 AM Marco Martin wrote: > > > > I fixed CI, passes now > Thanks for correcting that. As Friedrich raised the initial concerns it would be nice to have him confirm that the code quality issues

Re: KSvg in kdereview

2023-06-21 Thread Harald Sitter
LGTM now +2 On Wed, Jun 21, 2023 at 10:04 AM Marco Martin wrote: > > I fixed CI, passes now > > On Tue, Jun 20, 2023 at 8:44 PM Ben Cooksley wrote: > > > > Hi all, > > > > Sysadmin has just received a request to move this repository to Frameworks, > > however after seeing some of the comments

Re: KSvg in kdereview

2023-06-21 Thread Marco Martin
I fixed CI, passes now On Tue, Jun 20, 2023 at 8:44 PM Ben Cooksley wrote: > > Hi all, > > Sysadmin has just received a request to move this repository to Frameworks, > however after seeing some of the comments raised here regarding the > repository I took a look myself to see if they had been