Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-29 Thread Alberto Jiménez Ruiz
oesn't, parent calls emitsResult twice. Result after patch: kioclient shows a MessageBox telling the copy operation could not be completed. Thanks, Alberto Jiménez Ruiz

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-28 Thread Alberto Jiménez Ruiz
t=alienWidget@entry=0x8c1fc0, > > nativeWidget=0x7fffdce0, buttonDown=buttonDown@entry=0x73fa4ba0 > > , lastMouseReceiver=..., > > spontaneous=true) at > > /home/kde-devel/frameworks/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2770 > > #43 0x73b

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-24 Thread Alberto Jiménez Ruiz
marked as submitted. Review request for kdelibs, Albert Astals Cid and David Faure. Changes --- Submitted with commit e60e8b96b211290e330c7ff6a3b84b20ab85850d by David Faure on behalf of Alberto Jiménez Ruiz to branch KDE/4.14. Bugs: 333436 http://bugs.kde.org/show_bug.cgi?id=333436

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-22 Thread Alberto Jiménez Ruiz
ter patch: kioclient shows a MessageBox telling the copy operation could not be completed. Thanks, Alberto Jiménez Ruiz

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-22 Thread Alberto Jiménez Ruiz
r/125613/#review87242 --- On Oct. 22, 2015, 7:31 a.m., Alberto Jiménez Ruiz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread Alberto Jiménez Ruiz
ter patch: kioclient shows a MessageBox telling the copy operation could not be completed. Thanks, Alberto Jiménez Ruiz

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread Alberto Jiménez Ruiz
> which is why I didn't set an error code here. Please explain why this is > > needed. > > Alberto Jiménez Ruiz wrote: > The comment exactly says: (If we can't list a subdir, the result is still > ok). > > I interpret it like the result is not ok if the

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread Alberto Jiménez Ruiz
- Alberto --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125613/#review87048 --- On Oct. 17, 2015, 2:02 p.m., Alberto Jiménez Ruiz wr

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-15 Thread Alberto Jiménez Ruiz
wice. Result after patch: kioclient shows a MessageBox telling the copy operation could not be completed. Thanks, Alberto Jiménez Ruiz

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-15 Thread Alberto Jiménez Ruiz
r/125613/#review86866 --- On Oct. 14, 2015, 10:04 a.m., Alberto Jiménez Ruiz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-13 Thread Alberto Jiménez Ruiz
Result after patch: kioclient shows a MessageBox telling the copy operation could not be completed. Thanks, Alberto Jiménez Ruiz

Review Request 125613: Race condition and error notification loss in ListJob

2015-10-12 Thread Alberto Jiménez Ruiz
completed. Thanks, Alberto Jiménez Ruiz

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-12 Thread Alberto Jiménez Ruiz
wice. Result after patch: kioclient shows a MessageBox telling the copy operation could not be completed. Thanks, Alberto Jiménez Ruiz

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-12 Thread Alberto Jiménez Ruiz
lls slotError, > which calls slotsFinished and emitResult. > The result of the child gets collected by parent. slotResult of parent gets > called, removes subjob and emitsresult because there are no subjobs left. > ---That's fine as long as the slave associated with the parent emits finished > before the child fails. If it doesn't, parent calls emitsResult twice. > > > Result after patch: kioclient shows a MessageBox telling the copy operation > could not be completed. > > > Thanks, > > Alberto Jiménez Ruiz > >

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-12 Thread Alberto Jiménez Ruiz
> On Oct. 12, 2015, 7:29 p.m., Albert Astals Cid wrote: > > Do you think you can add an unittest for this or is it hard to recreate the > > conditionts? > > Alberto Jiménez Ruiz wrote: > It happens to very few people. Most developers tried to reproduce bug &