Re: Review Request 120782: Allow stand-alone build of konqueror

2014-10-29 Thread Dan Vrátil
-konqueror.h.cmake PRE-CREATION konqueror/src/CMakeLists.txt 0f6767f konqueror/src/konqview.h e98ecba Diff: https://git.reviewboard.kde.org/r/120782/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 120781: Allow stand-alone build of keditbookmarks

2014-10-29 Thread Dan Vrátil
/r/120781/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 120782: Allow stand-alone build of konqueror

2014-10-28 Thread Dan Vrátil
/120782/#review69117 --- On Oct. 24, 2014, 5:12 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120782

Re: Review Request 120782: Allow stand-alone build of konqueror

2014-10-28 Thread Dan Vrátil
libkonq). Diffs (updated) - konqueror/CMakeLists.txt 37962ca konqueror/config-konqueror.h.cmake PRE-CREATION konqueror/src/CMakeLists.txt 0f6767f konqueror/src/konqview.h e98ecba Diff: https://git.reviewboard.kde.org/r/120782/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 120781: Allow stand-alone build of keditbookmarks

2014-10-28 Thread Dan Vrátil
/diff/ Testing --- Thanks, Dan Vrátil

Review Request 120781: Allow stand-alone build of keditbookmarks

2014-10-24 Thread Dan Vrátil
--- This patch modifies keditbookmarks/CMakeLists.txt so that keditbookmarks can be built standalone. Diffs - keditbookmarks/CMakeLists.txt 5b3d9c5 Diff: https://git.reviewboard.kde.org/r/120781/diff/ Testing --- Thanks, Dan Vrátil

Review Request 120782: Allow stand-alone build of konqueror

2014-10-24 Thread Dan Vrátil
/120782/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 113714: Call KXMLGUIFactory::reset() before we start building the UI in createGUI()

2013-11-11 Thread Dan Vrátil
and KXMLGUIBuilder instantiates a new KToolBar before inserting items. Diffs - kdeui/xmlgui/kxmlguiwindow.cpp aa4a067 Diff: http://git.reviewboard.kde.org/r/113714/diff/ Testing --- Thanks, Dan Vrátil

Review Request 113714: Call KXMLGUIFactory::reset() before we start building the UI in createGUI()

2013-11-07 Thread Dan Vrátil
/kxmlguiwindow.cpp aa4a067 Diff: http://git.reviewboard.kde.org/r/113714/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

2013-06-09 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110476/#review33973 --- Anyone please? :-) - Dan Vrátil On May 16, 2013, 9:38 p.m

Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

2013-05-16 Thread Dan Vrátil
://git.reviewboard.kde.org/r/110476/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 110099: Fix ksplash geometry when kscreen is used

2013-04-20 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110099/#review31347 --- Ship it! Ship It! - Dan Vrátil On April 20, 2013, 6:58 p.m

Review Request 110046: Don't format port number in a kio_sftp message

2013-04-16 Thread Dan Vrátil
://u...@host.tld:9000 shows Opening SFTP connection to host host.tld:9,000 when user's locales are using comma to separate thousands. Diffs - kioslave/sftp/kio_sftp.cpp f493477 Diff: http://git.reviewboard.kde.org/r/110046/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 109945: [Screenlocker] Clear password field on Escape keypress

2013-04-10 Thread Dan Vrátil
/screenlocker/greeter/greeter.h a0a1ac3 ksmserver/screenlocker/greeter/greeter.cpp f5918f9 ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml 3dd9fc0 Diff: http://git.reviewboard.kde.org/r/109945/diff/ Testing --- Thanks, Dan Vrátil

Review Request: Initialize datetime of tags in tags:// protocol

2012-12-25 Thread Dan Vrátil
--- Thanks, Dan Vrátil

Re: Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-30 Thread Dan Vrátil
://git.reviewboard.kde.org/r/107513/#review22795 --- On Nov. 29, 2012, 2:55 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-29 Thread Dan Vrátil
://git.reviewboard.kde.org/r/107513/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-29 Thread Dan Vrátil
/kfileplacesmodel.cpp 0192926 Diff: http://git.reviewboard.kde.org/r/107513/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request: Cache icon and accessibility in KFilePlacesItem

2012-10-25 Thread Dan Vrátil
, 2012, 9:13 p.m., Dan Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107030/ --- (Updated Oct. 24, 2012, 9:13 p.m

Review Request: Cache icon and accessibility in KFilePlacesItem

2012-10-24 Thread Dan Vrátil
querying udisksd has impact on Dolphin start up time (and with this patch it has similar impact on the dialog show-up time). Diffs - kfile/kfileplacesitem.cpp 3ada0c3 kfile/kfileplacesitem_p.h 3c6bd30 Diff: http://git.reviewboard.kde.org/r/107030/diff/ Testing --- Thanks, Dan