Re: Falkon in kdereview

2018-04-03 Thread David Rosca
On Sun, Mar 25, 2018 at 11:08 PM, David Rosca <now...@gmail.com> wrote: > On Sat, Mar 24, 2018 at 7:58 PM, Dr.-Ing. Christoph Cullmann > <cullm...@absint.com> wrote: >> Hi, >> >> no objections from my side, >> >> just a note that we need to take

Re: Falkon in kdereview

2018-03-25 Thread David Rosca
fest compliance is done I hope. Licensing should be ok now too. David > > Greetings > Christoph > > - Am 20. Mrz 2018 um 13:40 schrieb nowrep now...@gmail.com: > >> On Wed, Feb 28, 2018 at 12:10 PM, David Rosca <now...@gmail.com> wrote: >>> Hi, >>>

Re: Falkon in kdereview

2018-03-20 Thread David Rosca
On Wed, Feb 28, 2018 at 12:10 PM, David Rosca <now...@gmail.com> wrote: > Hi, > I'd like to request review for Falkon. > All issues that were pointed out are now fixed. It's been in kdereview for over two weeks now, so if there are no objections I will request move to extra

Re: Falkon in kdereview

2018-03-03 Thread David Rosca
On Sat, Mar 3, 2018 at 6:47 PM, Albert Astals Cid <aa...@kde.org> wrote: > El dimecres, 28 de febrer de 2018, a les 12:10:36 CET, David Rosca va > escriure: >> Hi, >> I'd like to request review for Falkon. >> >> It's been actually in kdereview for some time alr

Falkon in kdereview

2018-02-28 Thread David Rosca
Hi, I'd like to request review for Falkon. It's been actually in kdereview for some time already, but I never got to properly request review, sorry about that. There is a project set up in bugzilla, CI build and code should be in accordance with guidelines too. There are also some autotests,

Moving libbluedevil to unmaintained

2015-04-08 Thread David Rosca
Hi all, with Bluedevil now ported to BluezQt and with regard to no more kdelibs4 Bluedevil releases, I will no longer work on libbluedevil. Porting from libbluedevil to BluezQt is pretty straightforward (only problem might be async initialization), so I suggest to anyone still using libbluedevil

Re: Review request: QBluez

2015-03-13 Thread David Rosca
, Jonathan Riddell j...@jriddell.org wrote: On Thu, Mar 12, 2015 at 08:23:22PM +0100, David Rosca wrote: Done. It's in kdereview now: https://projects.kde.org/projects/kdereview/bluez-qt Woo, lovely. Best post to plasma-devel about that (it's been posted around lots already but best to cover all

Re: [kde-frameworks-devel] Review request: QBluez

2015-03-12 Thread David Rosca
On Wed, Mar 11, 2015 at 6:49 PM, Jonathan Riddell j...@jriddell.org wrote: The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which

Re: Review request: QBluez

2015-03-02 Thread David Rosca
:24:16, David Rosca va escriure: Still failing here Oops, sorry. It's because the problem is not that you are running Bluez 4, but because the method call is rejected (auth issue?). Anyway, I modified the tests again so that it now checks whether the Bluez 5 is running and is functional

Re: Review request: QBluez

2015-02-21 Thread David Rosca
to GetManagedObjects succeeds). It should catch your error and correctly skip the tests now. David On Fri, Feb 20, 2015 at 9:57 PM, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 18 de febrer de 2015, a les 11:50:01, David Rosca va escriure: If it's an expected situation, handle the situation. I have

Re: Review request: QBluez

2015-02-18 Thread David Rosca
febrer de 2015, a les 10:40:44, David Rosca va escriure: Hi all, I'd like to ask for a review of the QBluez library [1]. Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. Also tried

Re: Review request: QBluez

2015-02-18 Thread David Rosca
will modify those tests to be skipped if Bluez 4 is detected. David On Tue, Feb 17, 2015 at 11:00 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 17 de febrer de 2015, a les 22:39:16, David Rosca va escriure: That would work i guess, note it's not only about the project name, but also about

Re: Review request: QBluez

2015-02-18 Thread David Rosca
. By any chance, are you running Bluez 4? It doesn't have the DBus ObjectManager, so that call should fail like that. David On Tue, Feb 17, 2015 at 10:23 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: Using Q* is usually

Review request: QBluez

2015-02-17 Thread David Rosca
generated documentation here [4]. Thanks, David Rosca [1] http://quickgit.kde.org/?p=scratch%2Fdrosca%2Fqbluez.git [2] https://github.com/nowrep/qbluez-plasmoid [3] https://projects.kde.org/projects/kde/workspace/bluedevil/repository/show?rev=qbluez [4] http://david.rosca.cz/qbluez-apidoc/html/