Re: Review Request 112880: Added KColorSchemeToken class.

2013-12-04 Thread Denis Kuplyakov
it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-29 Thread Denis Kuplyakov
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Denis Kuplyakov wrote: Yes I will finish it, when have time. There are many

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-28 Thread Denis Kuplyakov
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Denis Kuplyakov wrote: Yes I will finish it, when have time. There are many

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-10 Thread Denis Kuplyakov
. - Denis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review42069 --- On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-09 Thread Denis Kuplyakov
readable. (Same issue for all the other methods.) Denis Kuplyakov wrote: I have tried it, but have such errors: Error: Unknown method parameter type: QPalette::ColorGroup See this: http://qt-project.org/forums/viewthread/10308/ . It seems that the int is only way

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-09 Thread Denis Kuplyakov
readable. (Same issue for all the other methods.) Denis Kuplyakov wrote: I have tried it, but have such errors: Error: Unknown method parameter type: QPalette::ColorGroup See this: http://qt-project.org/forums/viewthread/10308/ . It seems that the int is only way

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Denis Kuplyakov
, rather than letting the apps do it on their own? The NEED TO FIX in the description can be removed, right? About the branch: I see that the request is correctly for 5.0 - which means less merging trouble, so it sounds good to me :) Denis Kuplyakov wrote: We can register

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review41068 --- On Sept. 29, 2013, 4:27 p.m., Denis Kuplyakov wrote

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
branch. Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
/112880/#review41002 --- On Sept. 29, 2013, 4:27 p.m., Denis Kuplyakov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-24 Thread Denis Kuplyakov
/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
://git.reviewboard.kde.org/r/112880/diff/ Testing --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov

Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
17570fd kdeui/colors/kcolorscheme.cpp a6650ac kdeui/colors/kcolorschemetoken.h PRE-CREATION kdeui/colors/kcolorschemetoken.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112880/diff/ Testing --- Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
/diff/ Testing (updated) --- I've tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40458 --- On Sept. 22, 2013, 10:17 a.m., Denis Kuplyakov wrote

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40458 --- On Sept. 22, 2013, 10:17 a.m., Denis Kuplyakov wrote

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-22 Thread Denis Kuplyakov
tested it with KReversi's deniskup/gsoc2013/newdesign branch. Thanks, Denis Kuplyakov