Hi Ian, Review is to reopened!
I also use "Buzilla_token" as param for login request. But use of "token" as param for attachement works. Frédéric On Fri, Sep 26, 2014 at 7:11 PM, Ian Wadham <iandw...@gmail.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120376/ > > On September 26th, 2014, 11:54 a.m. UTC, *Ian Wadham* wrote: > > Hi Frédéric, > > As announced on KDE Core devel, in > http://lists.kde.org/?l=kde-core-devel&m=141016488132293&w=2 about 3 weeks > ago, I also am working on Dr Konqi. > > I am about to publish a general patch, which is aimed at the present problem > posed by the change to tokens in Bugzilla > https://bugs.kde.org/show_bug.cgi?id=337742, but also intends to avoid such > problems in future and to be forward-portable to KF5. My approach is to check > the version number of the Bugzilla software and to switch to whichever > security method is appropriate for that version: cookies, tokens or > passwords-only. > > Of course, my patch will implement tokens for the time being, but the idea is > to switch automatically to passwords-only when the time comes, without any > new release of KDE software being necessary. See > http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/WebService.html#LOGGING_IN > in the documentation for Bugzilla 4.5.5 (the next version), as opposed to > 4.4.5 (the current version). Bugzilla 4.5.5 allows tokens, but I believe they > will be discontinued at some stage, though I cannot put my finger on where I > have seen that discussion. > > This should avoid users having to experience further bugs in Dr Konqi's > connection to bugs.kde.org. My patch is also intended to be extendable, so > that Dr Konqi can be updated and re-released, ahead of time, if any further > feature change is announced by Bugzilla and could adversely affect Dr Konqi. > > On September 26th, 2014, 3:28 p.m. UTC, *Frédéric Sheedy* wrote: > > Great, good news! My patch was only a quick fix to what you are doing. > > I did not mean that you should drop what you are doing and discard this > review and patch completely... :-) Instead, we should work together and each > be aware of what the other is doing. > > Please revive your patch and this review. > > From what I can tell, the patch (after review and shipping) will be good > immediately and at least until the version after Bugzilla 4.5.x. Also, your > patch has some improvements to the testing, which is important. And I think > we need to get a fix into the closing versions of KDE 4 ASAP (next deadline > Thursday, 9 October). My fixes will be more long-term and I am running short > of days to work on them, due to other commitments, and anyway they may take a > while to review... So please revive your review and patch, Frédéric. > > One immediate comment: I found that I could retrieve the token by using the > tag "token", but I could not use "token" in the "args" map. I had to use > "Bugzilla_token". I have no idea why that is. I am using an Apple OS X > platform, but that should not make a difference to a web dialog. > > > - Ian > > On September 26th, 2014, 3:28 p.m. UTC, Frédéric Sheedy wrote: > Review request for KDE Runtime. > By Frédéric Sheedy. > > *Updated Sept. 26, 2014, 3:28 p.m.* > *Bugs: * 337742 <http://bugs.kde.org/show_bug.cgi?id=337742> > *Repository: * kde-runtime > Description > > Bugzilla 4.4.5 now request token to create report. > > Testing > > Testing was done using crashtest program in drkonqui folder on > https://bugstest.kde.org > > Create new bug report and add attachement works now. > > Diffs > > - drkonqi/bugzillalib.h (570169b) > - drkonqi/bugzillalib.cpp (f74753c) > - drkonqi/tests/bugzillalibtest/bugzillalibtest.cpp (46c95b6) > > View Diff <https://git.reviewboard.kde.org/r/120376/diff/> >
