Re: Review of special packager access

2016-07-09 Thread Michael Palimaka
d check over their ~/.ssh/authorized keys > file and remove any outdated keys. I confirm that Gentoo is still active. Our primary contacts are: Johannes Huber <j...@gentoo.org> Michael Palimaka <kensing...@gentoo.org> We have also reviewed our ~/.ssh/authorized_keys. Kind regards, Michael

Re: Please review Snorenotify (Finish Incubating)

2015-11-19 Thread Michael Palimaka
On 19/11/15 09:48, Hannah von Reth wrote: > Hi there, > > Mario guided me until now through the incubation process and we think it > is time to move Snorenotify from playground to extragear. > Snorenotify is a notification framework supporting Linux, Windows and > Mac OSX. > It is not meant to

Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake

2015-10-09 Thread Michael Palimaka
. - Michael Palimaka On Oct. 8, 2015, 5:50 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Syncing ECM release number with KF5

2015-04-03 Thread Michael Palimaka
On 02/04/15 21:29, Stephen Kelly wrote: I have no particular objection, So, what needs to be done to get this synced up? Bump the version in the CMakeLists.txt and update some release-tarball-creating script? David I guess the latter is for you? Thanks, Steve. Can we at least find out

Re: Syncing ECM release number with KF5

2015-03-28 Thread Michael Palimaka
On 28/03/15 03:48, Alex Merry wrote: On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote: Hello, ECM release numbers are in sync with KF5 release numbers, except for the major component. This means that if you want to build the 5.x.y release you have to download the 1.x.y release of

Re: Review Request 105895: Fix hang in kcm_useraccount

2014-07-24 Thread Michael Palimaka
: https://git.reviewboard.kde.org/r/105895/diff/ Testing --- Tested all combinations of password required and name change permitted, with success. Thanks, Michael Palimaka

Re: Review Request 109932: Remove redundant linking to Xfixes

2014-07-22 Thread Michael Palimaka
://git.reviewboard.kde.org/r/109932/diff/ Testing --- Thanks, Michael Palimaka

Best practice for libraries supporting both Qt4 and Qt5

2013-11-29 Thread Michael Palimaka
Hi, Is there an established best practice for libraries to support both Qt4 and Qt5? Currently, some libraries such as phonon rename their Qt5 versions, permitting full parallel installation and usage (even of development and CMake config files). Other libraries such as attica bump the

Re: Review Request 109932: Remove redundant linking to Xfixes

2013-09-16 Thread Michael Palimaka
--- Thanks, Michael Palimaka

Re: Review Request 112458: Fix build with jpeg-9

2013-09-03 Thread Michael Palimaka
from int to typedef enum { FALSE = 0, TRUE = 1 }. Diffs - khtml/imload/decoders/jpegloader.cpp ea255726fdf1c310826c0037583aca3c5c741245 Diff: http://git.reviewboard.kde.org/r/112458/diff/ Testing --- Also tested against jpeg-8d (previous stable) and libjpeg-turbo. Thanks, Michael

Review Request 112200: Remove unused CMake qimageblitz includes and links

2013-08-29 Thread Michael Palimaka
://git.reviewboard.kde.org/r/112200/diff/ Testing --- Thanks, Michael Palimaka

Re: Review Request 109809: Extend Mesa 9.1 restriction to SandyBridge

2013-04-03 Thread Michael Palimaka
://bugs.kde.org/show_bug.cgi?id=317427 Diffs - kwin/lanczosfilter.cpp 91f701a6af7d2efec9b273a3f3eb3ef3addb6b84 Diff: http://git.reviewboard.kde.org/r/109809/diff/ Testing --- Thanks, Michael Palimaka

Review Request 109607: Remove Google Gadgets support

2013-03-21 Thread Michael Palimaka
--- Thanks, Michael Palimaka

Review Request: Respect PYTHONDONTWRITEBYTECODE environmental variable

2012-11-08 Thread Michael Palimaka
, but for KDE/4.10) This addresses bug 276151. http://bugs.kde.org/show_bug.cgi?id=276151 Diffs - cmake/modules/PythonMacros.cmake 785093e44b88a9be7d5d601fdd95f559af80e164 Diff: http://git.reviewboard.kde.org/r/107248/diff/ Testing --- Thanks, Michael Palimaka

Re: Review Request: Fix hang in kcm_useraccount

2012-08-14 Thread Michael Palimaka
9f75d4aa75b41acec84e7798c789d4226ca3fab9 kdepasswd/kcm/main.cpp 5a5248e545cc75433024ae0464ac9f3e05b71900 Diff: http://git.reviewboard.kde.org/r/105895/diff/ Testing (updated) --- Tested all combinations of password required and name change permitted, with success. Thanks, Michael Palimaka

Re: Review Request: Fix hang in kcm_useraccount

2012-08-10 Thread Michael Palimaka
On 2012-08-10 02:46, Rolf Eike Beer wrote: Ehm, no. readLine() unconditionally calls readAll(). But that will also clear the input buffer of the process object. So there is nothing left to read on the next readLine() or readAll() call. Eike So you are saying: - readAll clears the buffer -

Re: Review Request: Fix hang in kcm_useraccount

2012-08-10 Thread Michael Palimaka
On 2012-08-11 01:02, Rolf Eike Beer wrote: Am Samstag 11 August 2012, 00:11:37 schrieb Michael Palimaka: So you are saying: - readAll clears the buffer - readLine unconditionally calls readAll - readLine may be called multiple times to read multiple lines Is that correct? That's how

Re: Review Request: Fix hang in kcm_useraccount

2012-08-09 Thread Michael Palimaka
On 2012-08-09 17:06, Rolf Eike Beer wrote: You have a nice way trying to say I'm a moron. Thank you. ;) I am not trying to say that! I do not pretend to be any expert, and and the more eyes the better. Your patch isn't technically ideal as it does the same operation on data multiple times.

Re: Review Request: Fix hang in kcm_useraccount

2012-08-07 Thread Michael Palimaka
by login.defs * Error presented and no change processed with prohibited by login.defs Thanks, Michael Palimaka

Review Request: Fix hang in kcm_useraccount

2012-08-06 Thread Michael Palimaka
, Michael Palimaka

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-10 Thread Michael Palimaka
--- On July 1, 2012, 4:23 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105402

Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-01 Thread Michael Palimaka
://git.reviewboard.kde.org/r/105402/diff/ Testing --- Thanks, Michael Palimaka

Review Request: Install additional headers from libkonq

2012-04-23 Thread Michael Palimaka
/konq/CMakeLists.txt 8ecbfa9d33b4bc2cb3e54bc0da7ba5d2010f6964 Diff: http://git.reviewboard.kde.org/r/104700/diff/ Testing --- Thanks, Michael Palimaka

Re: Review Request: Add option to control PAM support

2012-01-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103818/#review10198 --- On Jan. 29, 2012, 10:35 a.m., Michael Palimaka wrote

Review Request: Add option to control PAM support

2012-01-29 Thread Michael Palimaka
/UnixAuth.cmake 904f0cb Diff: http://git.reviewboard.kde.org/r/103818/diff/diff Testing --- For me, both kcheckpass and KDM link against libcrypt instead of PAM and work fine when -DWITH_PAM=no is specified. Thanks, Michael Palimaka