Re: Why is C90 enforced in KDE?

2015-12-07 Thread Patrick Spendrin
Am 07.12.2015 um 21:36 schrieb Thomas Lübking: > On Montag, 7. Dezember 2015 17:22:47 CEST, Boudewijn Rempt wrote: > >> There are two sides, of course: if making it easier for a distribution >> to package KDE software makes it harder for an application to be packaged >> for another distribution, w

Re: Review Request 114214: remove QDesktopWidget global static

2013-12-12 Thread Patrick Spendrin
f: http://git.reviewboard.kde.org/r/114214/diff/ Testing --- On Windows msvc2010 ;-) Thanks, Patrick Spendrin

Re: Review Request 114214: remove QDesktopWidget global static

2013-11-29 Thread Patrick Spendrin
ated) --- On Windows msvc2010 ;-) Thanks, Patrick Spendrin

Review Request 114214: remove QDesktopWidget global static

2013-11-29 Thread Patrick Spendrin
Startup() [f:\dd\vctools\crt_bld\self_x86\crt\src\crtdll.c @ 526] at 0x54372630 ... I don't think it breaks anything. Diffs - kdeui/windowmanagement/kwindowsystem_win.cpp e5b3a23 Diff: http://git.reviewboard.kde.org/r/114214/diff/ Testing --- Thanks, Patrick Spendrin

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-21 Thread Patrick Spendrin
://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits . Diffs - tier1/solid/src/solid/processor.h ce4f0e1 tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 Diff: http://git.reviewboard.kde.org/r/108845/diff/ Testing --- Windows Thanks, Patrick Spendrin

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-15 Thread Patrick Spendrin
> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > kioslave/thumbnail/CMakeLists.txt, line 160 > > <http://git.reviewboard.kde.org/r/112009/diff/2/?file=178067#file178067line160> > > > > this could be moved out of the parentheses right? > >

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-13 Thread Patrick Spendrin
> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > > > Patrick Spendrin wrote: > In general of course: thanks for your review request, one of the small > nice overdue features! > How does this work on Linux, e.g. do the changes to the .desktop f

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-13 Thread Patrick Spendrin
> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > > > Patrick Spendrin wrote: > In general of course: thanks for your review request, one of the small > nice overdue features! > How does this work on Linux, e.g. do the changes to the .desktop f

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-12 Thread Patrick Spendrin
> On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: > > In general of course: thanks for your review request, one of the small nice overdue features! How does this work on Linux, e.g. do the changes to the .desktop file affect Linux here?

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-12 Thread Patrick Spendrin
lt;http://git.reviewboard.kde.org/r/112009/#comment27799> See above comment. - Patrick Spendrin On Aug. 11, 2013, 1:59 p.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 111291: New Windows solid backend

2013-06-28 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111291/#review35257 --- Ship it! Ship It! - Patrick Spendrin On June 28, 2013, 6

Re: Review Request 105452: fix exports using Q_DECL_EXPORT

2013-05-29 Thread Patrick Spendrin
...@kde.org. Diffs - kdecore/localization/ktranscript.cpp 08ebf0e kdecore/util/kexportplugin.h 775ed48 Diff: http://git.reviewboard.kde.org/r/105452/diff/ Testing --- windows only. Thanks, Patrick Spendrin

Re: Review Request 105452: fix exports using Q_DECL_EXPORT

2013-05-29 Thread Patrick Spendrin
> On Feb. 8, 2013, 6:23 p.m., Albert Astals Cid wrote: > > What's the status on this? Should be discarded? Reworked? > > Patrick Spendrin wrote: > It needs to be reworked, because I doubt that the issue has vanished by > not looking at it. Ok, steveire fix

Re: Review Request 110462: Call new Instance dbus method on Windows when a KUniqueApplication is already running

2013-05-27 Thread Patrick Spendrin
ttp://git.reviewboard.kde.org/r/110462/#comment24561> Why do we still fail this function (exit(255)), even if we actually are still doing a meaningful action (activateWindowForProcess) here? - Patrick Spendrin On May 16, 2013, 10:21 a.m., Andre Heinecke

Re: Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

2013-05-23 Thread Patrick Spendrin
in emerge, there is another one in there which might also interest you. - Patrick Spendrin On March 2, 2013, 4:54 p.m., Michel Ludwig wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-05-22 Thread Patrick Spendrin
) - tier1/solid/src/solid/processor.h ce4f0e1 tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 Diff: http://git.reviewboard.kde.org/r/108845/diff/ Testing --- Windows Thanks, Patrick Spendrin

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-05-22 Thread Patrick Spendrin
ly, visit: http://git.reviewboard.kde.org/r/108845/#review32127 --- On Feb. 8, 2013, 1:09 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 105452: fix exports using Q_DECL_EXPORT

2013-02-12 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105452/#review26991 --- On July 5, 2012, 1:09 p.m., Patrick Spendrin wrote: > >

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-02-07 Thread Patrick Spendrin
/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 tier1/solid/src/solid/processor.h ce4f0e1 Diff: http://git.reviewboard.kde.org/r/108845/diff/ Testing --- Windows Thanks, Patrick Spendrin

Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-02-07 Thread Patrick Spendrin
baa1af2 tier1/solid/src/solid/processor.h ce4f0e1 Diff: http://git.reviewboard.kde.org/r/108845/diff/ Testing --- Windows Thanks, Patrick Spendrin

Re: playground/games/picmi moved to KDE Review

2012-07-26 Thread Patrick Spendrin
Am 26.07.2012 05:43, schrieb Andrius da Costa Ribas: > add_definitions(${KDE4_ENABLE_EXCEPTIONS}) seems to interfere with > RC.exe when I try to add a kde4_add_app_icon. > fatal error RC1106: invalid option: -EHsc > > any hint with that? probably this has to be set in a different way then, someth

Re: playground/games/picmi moved to KDE Review

2012-07-26 Thread Patrick Spendrin
Am 26.07.2012 05:30, schrieb Andrius da Costa Ribas: > Hello, > > In src/systemexception.h: > return m_msg.toStdString().c_str(); > ^ my Qt copy was built with no support to toStdString, please consider > changing it to: > return m_msg.toLatin1(); Nope, your Qt copy was build with stl support, th

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Patrick Spendrin
Am 25.07.2012 12:57, schrieb Jakob Gruber: > I spent this morning setting up KDE Windows (thanks SaroEngels for all > the help). The good news is that picmi > compiles and runs without any changes to the source code (mingw and KDE > 4.8). > > I have not set up a build with MSVC or KDE trunk, so I

Re: playground/games/picmi moved to KDE Review

2012-07-25 Thread Patrick Spendrin
Am 25.07.2012 10:13, schrieb Andras Mantia: > On Wednesday, July 25, 2012 08:57:13 AM Laszlo Papp wrote: >>> There was never a requirement for software that wants to be part of KDE to >>> work on Windows, and I'd like to keep this as it is. >> >> Perhaps, but I can still raise my personal opinion,

Review Request: fix exports using Q_DECL_EXPORT

2012-07-05 Thread Patrick Spendrin
/kexportplugin.h 775ed48 Diff: http://git.reviewboard.kde.org/r/105452/diff/ Testing --- windows only. Thanks, Patrick Spendrin

Re: kio and frameworks 5

2012-05-12 Thread Patrick Spendrin
Am 11.05.2012 22:33, schrieb Casper Clemence: > I'm want to start a discussion, put an idea out there. I am also being > pushy, on someone else's behalf. > > Although it may be a difficult discussion I think it would be a great > shame to miss the opportunity to have it. I'm not trying to tell any

Re: KDE/4.8 branch created

2011-12-20 Thread Patrick Spendrin
Am 20.12.2011 22:18, schrieb Dirk Mueller: > > Hi, > > As a preparation of KDE 4.8 RC1 I've created a KDE/4.8 branch for all > released > modules except for kdelibs, where I'm waiting for feedback if creating a 4.8 > branch makes sense for just one patch (see other mail today). I have at le

Re: Review Request: W7 Tab thumbnails in dolphin.

2011-10-03 Thread Patrick Spendrin
platforms (xp, vista & with mingw compilers) so that we have an idea which other problems are hidden in here. For the time until the 4.9 release, I think we can apply this as a patch against our builds. - Patrick Spendrin On Oct. 3, 2011, 1:25 a.m., Andrius da Costa Ribas w

Re: Review Request: W7 Tab thumbnails in dolphin.

2011-10-03 Thread Patrick Spendrin
-- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102758/ > --- > > (Updated Oct. 3, 2011, 1:25 a.m.) > > > Review request for KDE Base Apps, KDE Acce

Re: need to backport patch in kinit/kinit_win.cpp to 4.6

2011-03-09 Thread Patrick Spendrin
ckporting would actually be good. you can always just apply the patch by hand as we did with svn back then. regards, Patrick > > > > i5:~/src/kdelibs.was/kinit$ git show fd16288 > > commit fd16288cedadf8ccf469df8a7be296763f5003d8 > > Author: Patrick Spendrin > >