Re: Review Request 127823: Allow building without strigi on Linux

2016-08-18 Thread Pino Toscano
, as there were a couple of missing symbols -- see commit e328a020645899f25d0afccc196928783d6b59d1 which I just pushed. Otherwise, +1 (and the patch is landing in Debian soon). - Pino Toscano On May 3, 2016, 12:06 p.m., Antonio Rojas wrote

Re: libkgeomap

2015-01-28 Thread Pino Toscano
to release some extra library from time to time (*) should not be an huge overload. (*) not all the extra libraries bundled with digikam get changes in each release, so doing released only when having enough bugfixes/features is the best way to go -- Pino Toscano

Re: libkgeomap

2015-01-26 Thread Pino Toscano
as separate library. IMHO this is just matter of doing own releases of libkgeomap, possibly taking care of not breaking API/ABI in each release. -- Pino Toscano

Re: libkgeomap

2015-01-26 Thread Pino Toscano
as separate library. IMHO this is just matter of doing own releases of libkgeomap, possibly taking care of not breaking API/ABI in each release. -- Pino Toscano

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-30 Thread Pino Toscano
On Nov. 29, 2014, 10:20 p.m., Pino Toscano wrote: drkonqi/backtracegenerator.cpp, line 97 https://git.reviewboard.kde.org/r/121286/diff/3/?file=331098#file331098line97 Still hardcodes the debugger name; I'm not a drkonqui developer, so I cannot tell you exactly what to do

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-29 Thread Pino Toscano
/#comment49664 startsWith(libsystem_) endsWith(.dynlib) drkonqi/parser/backtraceparser.cpp https://git.reviewboard.kde.org/r/121286/#comment49665 This does not need a regexp. - Pino Toscano On Nov. 29, 2014, 10:03 p.m., René J.V. Bertin wrote

Re: Review Request 121286: Adding support for lldb in DrKonqi (step 1)

2014-11-28 Thread Pino Toscano
On Nov. 28, 2014, 11:09 p.m., Pino Toscano wrote: drkonqi/backtracegenerator.cpp, lines 97-100 https://git.reviewboard.kde.org/r/121286/diff/1/?file=331014#file331014line97 Shouldn't this rather be some attribute in the rc file, instead of hardcoding the lldb behaviour

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Pino Toscano
versions: GNU libc, not GCC, actually. - Pino Toscano On Nov. 17, 2014, 3:29 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147

Re: Review Request 121134: make KGlobal reference counting threadsafe

2014-11-16 Thread Pino Toscano
. - Pino Toscano On Nov. 16, 2014, 7:01 p.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134

Re: Review Request 120195: [OS X] make sure the appropriate menu items get put in the Application menu's About and Preferences items

2014-10-04 Thread Pino Toscano
/120195/#comment47343 Extra debug left? - Pino Toscano On Set. 25, 2014, 2:06 p.m., René J.V. Bertin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120195

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner system tray

2014-09-17 Thread Pino Toscano
for? If it is not used, please remove it, otherwise just include it unconditionally at the top (and not in the middle of the file, and just for Q_OS_MAC). - Pino Toscano On Set. 17, 2014, 5:48 p.m., René J.V. Bertin wrote

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner system tray

2014-09-17 Thread Pino Toscano
On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote: Two general notes: - please respect the kdelibs coding style, for example removing the extra spaces in instructions - please remove the extra kDebug Oops, I accidentally checked Ship it!, while this is totally not the case (rather

Re: Review Request 120149: [OS X] improved menubar experience: protected Preferences menu and cleaner system tray

2014-09-17 Thread Pino Toscano
On Set. 17, 2014, 6:13 p.m., Pino Toscano wrote: kdeui/actions/kaction.cpp, lines 150-179 https://git.reviewboard.kde.org/r/120149/diff/3/?file=312869#file312869line150 The whole setTextWithCorrectMenuRole is totally broken from an i18n point of view: - we don't use Qt's tr

Re: Review Request 114298: prevent ksplashqml crash when a theme does not exist or cannot be loaded

2013-12-04 Thread Pino Toscano
://git.reviewboard.kde.org/r/114298/#comment32271 What about just calling ::exit(2) to reach the stdlib function, avoiding the exitNow wrapper? - Pino Toscano On Dec. 4, 2013, 1:54 p.m., Harald Sitter wrote: --- This is an automatically

Re: Review Request 111341: Oxygenify KNetattach

2013-07-08 Thread Pino Toscano
icon). - Pino Toscano On July 1, 2013, 3:12 p.m., Rohan Garg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111341

Re: Review Request 110328: Add config option to silently create initial password-less wallet

2013-05-06 Thread Pino Toscano
::clear() { if (!isNull()) *this = QString(); } -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: kdev-python move to extragear -- once more

2013-03-12 Thread Pino Toscano
?) I'm still missing an example of a real world situation where this fork specifically would be a problem. There were many, provided by Sune Vuorela or myself, in various emails of this and the intial review thread [1]. [1] «Review of kdev-python for move to extragear» -- Pino Toscano

Re: kdev-python move to extragear -- once more

2013-03-09 Thread Pino Toscano
, this would put a non- trivial burden over packagers (and potentially also over self-compiling users). [1] OTOH you are not the only one -- hello Gilles Caulier! -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review Request 108592: Added some more operations in analitza

2013-01-28 Thread Pino Toscano
the litza part? IIRC it derives from the catalan verb analitzar (= analyze), see also http://www.catalandictionary.org/eng/?q=conjugator/analitzar/regular -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDEREVIEW: share like connect and plasmate

2013-01-03 Thread Pino Toscano
Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: On 3 January 2013 01:51, Pino Toscano p...@kde.org wrote: - PasswordAsker sounds like could be implemented on top of KPasswordDialog we have asked in #kde-devel and we have been informed that kdialogpassword isn't a safe

Re: KDEREVIEW: share like connect and plasmate

2013-01-02 Thread Pino Toscano
Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: On 2 January 2013 23:38, Pino Toscano p...@kde.org wrote: - BranchDialog sounds like could be replaced with KInputDialog::getText with a custom validator Still there. - CommitDialog, other than being a KDialog, should

Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Pino Toscano
-core/NepomukCoreConfig.cmake.in is broken (see NEPOMUK_CORE_LIB_DIR and NEPOMUK_CORE_LIBRARY). -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-17 Thread Pino Toscano
Alle lunedì 17 dicembre 2012, Alexander Neundorf ha scritto: On Monday 17 December 2012, Pino Toscano wrote: Alle lunedì 17 dicembre 2012, Ben Cooksley ha scritto: Currently build.kde.org is unable to successfully complete builds of kdeplasma-addons and Calligra due to recent changes

Re: Review of kdev-python for move to extragear

2012-12-06 Thread Pino Toscano
some CVE from time to time, so this would impose an extra burden on packagers (and self-compiling users which need to patch and upgrade on their own). -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Pino Toscano
/107520/#comment17395 This would be QFile::decodeName, not QString::fromLocal8Bit... but you don't need it either, since you have path already. - Pino Toscano On Nov. 29, 2012, 7:33 p.m., Mark Gaiser wrote

Re: Review Request: Fix KIO listDir entries batching

2012-11-29 Thread Pino Toscano
On Nov. 29, 2012, 7:48 p.m., Pino Toscano wrote: kioslave/file/file_unix.cpp, line 363 http://git.reviewboard.kde.org/r/107520/diff/1/?file=96853#file96853line363 This would be QFile::decodeName, not QString::fromLocal8Bit... but you don't need it either, since you have path

kde-workspace/4.9 messed up

2012-11-11 Thread Pino Toscano
Hi, somehow the master branch of kde-workspace has been merged in the KDE/4.9 branch, with obvious consequences. Can anyone please fix this mess? Thanks, -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDE-GTK-Config to KDEReview

2012-11-08 Thread Pino Toscano
it to kde-gtk-config.png -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Pino Toscano
to? -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KDE-GTK-Config to KDEReview

2012-11-07 Thread Pino Toscano
Hi, Alle mercoledì 7 novembre 2012, Aleix Pol ha scritto: On Wed, Nov 7, 2012 at 12:49 AM, Pino Toscano p...@kde.org wrote: Alle lunedì 5 novembre 2012, Aleix Pol ha scritto: Some months ago I pushed this project quite intensively so that right now we have a stable KCM for editing the GTK

Re: KDE-GTK-Config to KDEReview

2012-11-06 Thread Pino Toscano
minimal; is there really no way to have just one source with at most 1-2 «#if GTK_IS_VERSION(...)» blocks? also, doesn't glib/gtk offer some kind of functions to parse command line arguments (similar to getopt, KCmdLineArgs, etc)? I think that's enough for now... -- Pino Toscano signature.asc

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Pino Toscano
Hi, Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: On 3 November 2012 19:35, Pino Toscano p...@kde.org wrote: - a numer of .ui files sets bold/bigger texts, but using a qt rich text which forces a font size (and in few cases also the font face) and which is the correct

Re: KDEREVIEW: share like connect and plasmate

2012-11-05 Thread Pino Toscano
Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: On 4 November 2012 16:55, Pino Toscano p...@kde.org wrote: - the following binaries are installed in $prefix/bin: - plasmaengineexplorer - plasmakconfigxteditor - plasmaremoteinstaller - plasmate

Re: KDEREVIEW: share like connect and plasmate

2012-11-04 Thread Pino Toscano
Hi, Alle sabato 3 novembre 2012, Pino Toscano ha scritto: Alle giovedì 1 novembre 2012, Aaron J. Seigo ha scritto: This is to inform everyone that the plasmate and share-like-connect repositories have been moved into KDE Review so that, if all goes according to plan, we can move them

Re: KDEREVIEW: share like connect and plasmate

2012-11-03 Thread Pino Toscano
coming from other components) I think that's enough for now. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-29 Thread Pino Toscano
/konqsessionmanager.cpp http://git.reviewboard.kde.org/r/106503/#comment15545 i18n: remove the space before the question mark, please - Pino Toscano On Sept. 28, 2012, 4:45 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail

Re: Compiler version

2012-07-01 Thread Pino Toscano
Stable (Squeeze) is also 4.5 by default. Debian Stable (Squeeze) is 4.4.5 by default, with GCC 4.3.5 being provided too. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Binary compatiblity for liboxygenstyle.so

2012-02-24 Thread Pino Toscano
(liboxygenstyle.so.4) for API-/ABI- incompatible new versions of it. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Binary compatiblity for liboxygenstyle.so

2012-02-24 Thread Pino Toscano
Alle venerdì 24 febbraio 2012, Hugo Pereira Da Costa ha scritto: On 02/24/2012 12:01 PM, Pino Toscano wrote: Alle venerdì 24 febbraio 2012, Hugo Pereira Da Costa ha scritto: On 02/24/2012 11:43 AM, Pino Toscano wrote: Alle venerdì 24 febbraio 2012, Hugo Pereira Da Costa ha scritto

Re: Klipper

2011-05-17 Thread Pino Toscano
, then? Yay for buzzwords used at random! In other news, passing -DBUILD_klipper=OFF to cmake for kde-workspace should already make klipper not being compiled. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: Review Request: fix wrong file extension for kmplot

2011-04-18 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101059/#review2740 --- Ship it! I guess some typo when in created kde.xml (more than

Re: new kdevelop sessions runner for review

2011-03-21 Thread Pino Toscano
. -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KShutdown got to kde-runtime without review

2011-02-20 Thread Pino Toscano
Alle giovedì 17 febbraio 2011, Pino Toscano ha scritto: Alle giovedì 17 febbraio 2011, Ralf Habacker ha scritto: Am 17.02.2011 09:32, schrieb Pino Toscano: Alle giovedì 17 febbraio 2011, Ralf Habacker ha scritto: Am 17.02.2011 09:18, schrieb Ralf Habacker: Am 16.02.2011 20:40, schrieb

Re: KShutdown got to kde-runtime without review

2011-02-17 Thread Pino Toscano
can submit a review request and will do the review Can you please rename it to e.g. kdewin-shutdown or similar, given that there's already a kshutdown application for KDE for years? -- Pino Toscano signature.asc Description: This is a digitally signed message part.

Re: KShutdown got to kde-runtime without review

2011-02-17 Thread Pino Toscano
Alle giovedì 17 febbraio 2011, Ralf Habacker ha scritto: Am 17.02.2011 09:32, schrieb Pino Toscano: Alle giovedì 17 febbraio 2011, Ralf Habacker ha scritto: Am 17.02.2011 09:18, schrieb Ralf Habacker: Am 16.02.2011 20:40, schrieb Albert Astals Cid: Why? I'm currently the only

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/#review1190 --- Please also add the { } around single line blocks (as per

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Pino Toscano
On Feb. 4, 2011, 8:02 a.m., Pino Toscano wrote: Please also add the { } around single line blocks (as per kdelibs coding style). Dawit Alemayehu wrote: Lets us forget about such nitpicks, okay... If such unnecessary coding styles were to be enforced, there would be so many lines

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100539/#review1199 --- Still the coding style issues to fix in the new code.

Re: kdelibs, kdebase moving to Git this Saturday

2011-02-01 Thread Pino Toscano
tags and branches), where are the wallpapers now? -- Pino Toscano signature.asc Description: This is a digitally signed message part.