Re: Review Request: Fix KGlobalSettingsTest failure

2011-07-28 Thread Rolf Eike Beer
void KGlobalSettingsTest::initTestCase() { +// Some signals are only emitted when we are running a full KDE session. If +// we are not then KDE applications follow the platform palette and font +// settings. +setenv(KDE_FULL_SESSION, 1, 1); + qputenv()? Eike

Re: Review Request: Fix logic with clear-button animation in klineedit (notably at first try) and address bug 268898.

2011-07-27 Thread Rolf Eike Beer
Details: - fixes the somewhat incorrect logic in KLineEditButton::animateVisible - simplifies KLineEdit::updateClearButtonIcon consequently. Please test this also when using Konqueror and edit fields (e.g. login boxes). There have been some bad regressions about KLineEdit popping up in

Re: Hook behaviour change

2011-07-20 Thread Rolf Eike Beer
Am Mittwoch, 20. Juli 2011, 10:20:45 schrieb Ben Cooksley: Hi all, The KDE Git repository hooks have been adjusted to send emails in a SPF compliant manner. This means that the address n...@kde.org will be used in the MAIL FROM component of the SMTP transaction. The From: field of emails

Re: CDash of kdelibs

2011-07-20 Thread Rolf Eike Beer
Am Dienstag, 19. Juli 2011, 09:03:17 schrieb Volker Krause: On Monday 18 July 2011 21:21:36 Alexander Neundorf wrote: Volker, are you still doing make Nightly ? well, something inbetween I guess, manual ctest calls but not using the script in quality. If so, this is quite limited and

Re: CDash of kdelibs

2011-07-18 Thread Rolf Eike Beer
Am Sonntag, 17. Juli 2011, 12:47:36 schrieb Rolf Eike Beer: When I look at the kdelibs test results at http://my.cdash.org/index.php?project=kdelibs I see the following things that IMHO need to be changed: -the limit of 3000 warnings is reached, do we need to increase the limit? We don't

cpp includes in http ioslave

2011-07-17 Thread Rolf Eike Beer
When one looks at kioslave/http/http.cpp it finds things like this: //string parsing helpers and HeaderTokenizer implementation #include parsinghelpers.cpp //authentication handlers #include httpauthentication.cpp Which happens because e.g. parsinghelpers.cpp only consist of static functions.

CDash of kdelibs

2011-07-17 Thread Rolf Eike Beer
When I look at the kdelibs test results at http://my.cdash.org/index.php?project=kdelibs I see the following things that IMHO need to be changed: -the limit of 3000 warnings is reached, do we need to increase the limit? -the moc files are counted in the coverage results even if

Re: CDash of kdelibs

2011-07-17 Thread Rolf Eike Beer
Am Sonntag 17 Juli 2011, 12:58:35 schrieben Sie: On Sunday 17 July 2011, Rolf Eike Beer wrote: -the moc files are counted in the coverage results even if CTestConfig.cmake contains set(CTEST_CUSTOM_COVERAGE_EXCLUDE .moc$ moc_ ui_) So something is wrong there. This also adds

Re: cpp includes in http ioslave

2011-07-17 Thread Rolf Eike Beer
Am Sonntag, 17. Juli 2011, 13:14:39 schrieb Dawit A: On Sun, Jul 17, 2011 at 6:38 AM, Rolf Eike Beer k...@opensource.sf-tec.de wrote: When one looks at kioslave/http/http.cpp it finds things like this: //string parsing helpers and HeaderTokenizer implementation #include

Re: grantlee-0.1.8 build failed on arm7

2011-06-21 Thread Rolf Eike Beer
Sune Vuorela wrote: diff --git a/templates/lib/abstractlocalizer.cpp b/templates/lib/abstractlocalizer.cpp index 4e5b15d..104d888 100644 --- a/templates/lib/abstractlocalizer.cpp +++ b/templates/lib/abstractlocalizer.cpp @@ -46,8 +46,8 @@ QString AbstractLocalizer::localize( const QVariant

Re: KDM plans and lightDM

2011-06-13 Thread Rolf Eike Beer
Martin Gräßlin wrote: On Monday 13 June 2011 21:10:36 Alex Fiestas wrote: Also, since the last Ubuntu Development Summit I started to look into lightDM[1] as a possible alternative (at least for my use), I event managed to patch kdisplaymanager.cpp to play nice with it. To me the

Re: Review Request: Add a FindQtMobility.cmake file

2011-06-11 Thread Rolf Eike Beer
Am Freitag, 10. Juni 2011, 19:18:55 schrieb Arjen Hiemstra: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101568/ --- Review

Review Request: Update KActionCollection member documentation

2011-06-02 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101494/ --- Review request for kdelibs. Summary --- KActionCollection is missing

Re: Review Request: Patch for FTP ioslave unnecessarily asks for password

2011-04-12 Thread Rolf Eike Beer
This raises the question of how to test anonymous login on a site with cached auth though -- well, there's always the option of renaming stuff in kwalletmanager ;) ftp://ftp@site usually works, ftp://anonymous@site may also work. Eike

Re: KWallet changes between 4.4 and 4.6?

2011-04-04 Thread Rolf Eike Beer
Am Montag, 4. April 2011, 16:30:04 schrieb Stephen Kelly: Hi, Distros are still shipping KDEPIM 4.4 with their next release along with kde{,pim}libs 4.6. I'm testing it and getting errors like http://starsky.19inch.net/~jr/tmp/kmail1.png and then this one in a dialog: There have

Re: Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

2011-02-15 Thread Rolf Eike Beer
On Tuesday, 15 de February de 2011 07:53:15 Rolf Eike Beer wrote: Since I have some of these machines: is there any detail on this available somewhere? Does this count for HP-UX only or also for Linux? You can find the info in Qt's source code: src/corelib/arch/qatomic_parisc.h and src

Re: Use Q_GLOBAL_STATIC where K_GLOBAL_STATIC is not needed?

2011-02-14 Thread Rolf Eike Beer
Am Donnerstag 10 Februar 2011, 23:41:13 schrieb Thiago Macieira: On Thursday, 10 de February de 2011 17:11:42 Michael Pyne wrote: I say this as someone who uses QAtomicInt assuming a mode of operation that is not explicitly documented (i.e. it is safe to initialize its memory with 0 and

Re: release schedule calendar

2010-12-02 Thread Rolf Eike Beer
Heya folks :) toma is awesome and because he's awesome he created http://www.kde.org/releaseschedule.ics after I asked him to. We've had ics files for each cycle already but you'd need to subscribe to the new one each cycle. This one now combines them all and you can subscribe to it in your

Re: release schedule calendar

2010-11-29 Thread Rolf Eike Beer
Heya folks :) toma is awesome and because he's awesome he created http://www.kde.org/releaseschedule.ics after I asked him to. We've had ics files for each cycle already but you'd need to subscribe to the new one each cycle. This one now combines them all and you can subscribe to it in your

<    1   2