[kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Àlex Fiestas
Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas. Committed on 15/04/2013 at 12:24. Pushed by afiestas into branch 'master'. Disable KHostnameD in KDED KHostnameD monitors the hostname by polling gethostname every 5 seconds to adapt some bits of the environment in case the

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Rolf Eike Beer
Am 15.04.2013 12:43, schrieb Àlex Fiestas: Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas. Committed on 15/04/2013 at 12:24. Pushed by afiestas into branch 'master'. Disable KHostnameD in KDED KHostnameD monitors the hostname by polling gethostname every 5 seconds to

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Martin Sandsmark
On Mon, Apr 15, 2013 at 12:43:21PM +0200, Àlex Fiestas wrote: Git commit 8d99f863724c6fe76d008da4455fa177af2ee3ee by Àlex Fiestas. Committed on 15/04/2013 at 12:24. Pushed by afiestas into branch 'master'. I thought kdelibs master was closed for everything except bug fixes? And why didn't

Re: Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Martin Sandsmark
On Mon, Apr 15, 2013 at 01:17:19PM +0200, Martin Gräßlin wrote: well not stupidly polling is a bug fix, isn't it? That's really trying to twist semantics, IMHO. Polling every five seconds like it is intended to is not a bug, and now it breaks even worse (by locking out everyone who change their

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Sebastian Kügler
On Monday, April 15, 2013 13:39:34 Martin Sandsmark wrote: On Mon, Apr 15, 2013 at 01:17:19PM +0200, Martin Gräßlin wrote: well not stupidly polling is a bug fix, isn't it? That's really trying to twist semantics, IMHO. Polling every five seconds like it is intended to is not a bug,

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Martin Sandsmark
On Mon, Apr 15, 2013 at 02:04:43PM +0200, Sebastian Kügler wrote: Polling every 5 seconds for a file that is rarely changed is a bug. What functionality does it break? I'm not saying it's not suboptimal, and it can be solved in better ways, but I would in no way consider this a bug fix. --

Re: [kdelibs] kded: Disable KHostnameD in KDED

2013-04-15 Thread Daniel Nicoletti
2013/4/15 Martin Sandsmark martin.sandsm...@kde.org: On Mon, Apr 15, 2013 at 02:04:43PM +0200, Sebastian Kügler wrote: Polling every 5 seconds for a file that is rarely changed is a bug. What functionality does it break? I have seem this code before and would ask the same thing, it breaks the