Re: Including LayerShellQt in Plasma in time for 5.22

2021-04-15 Thread Aleix Pol
On Thu, Apr 1, 2021 at 7:12 PM Aleix Pol wrote: > > Hi, > In Plasma we have wanted a way to work with wlr_layer_shell for a > while, I'd tried taking this weird route, where we were adding it into > the project ad hoc, but it didn't really go anywhere. >

Re: Including LayerShellQt in Plasma in time for 5.22

2021-04-06 Thread Aleix Pol
On Tue, Apr 6, 2021 at 11:08 AM Harald Sitter wrote: > - I'm like a broken record at this point: some of the cmake files and > the json file lack licensing details. please run `reuse lint` to check > the list. it's incredibly close to being fully licensed > - you include KDEClangFormat but don't

Re: Including LayerShellQt in Plasma in time for 5.22

2021-04-06 Thread Harald Sitter
- I'm like a broken record at this point: some of the cmake files and the json file lack licensing details. please run `reuse lint` to check the list. it's incredibly close to being fully licensed - you include KDEClangFormat but don't actually seem to enable it - along a similar note: the code

Re: Including LayerShellQt in Plasma in time for 5.22

2021-04-05 Thread Vlad Zahorodnii
Hi, On 4/3/21 1:26 PM, Albert Astals Cid wrote: clang complains that /home/tsdgeos/devel/kde/layer-shell-qt/src/qwaylandlayershell_p.h:23:24: note: did you mean class here? QWaylandLayerShell(struct QtWayland::zwlr_layer_shell_v1 *shell); ^~

Re: Including LayerShellQt in Plasma in time for 5.22

2021-04-03 Thread Albert Astals Cid
El dijous, 1 d’abril de 2021, a les 19:12:30 CEST, Aleix Pol va escriure: > Hi, > In Plasma we have wanted a way to work with wlr_layer_shell for a > while, I'd tried taking this weird route, where we were adding it into > the project ad hoc, but it didn't really go anywhere. >

Re: Including LayerShellQt in Plasma in time for 5.22

2021-04-01 Thread Aleix Pol
On Thu, Apr 1, 2021 at 7:12 PM Aleix Pol wrote: > > Hi, > In Plasma we have wanted a way to work with wlr_layer_shell for a > while, I'd tried taking this weird route, where we were adding it into > the project ad hoc, but it didn't really go anywhere. >

Including LayerShellQt in Plasma in time for 5.22

2021-04-01 Thread Aleix Pol
Hi, In Plasma we have wanted a way to work with wlr_layer_shell for a while, I'd tried taking this weird route, where we were adding it into the project ad hoc, but it didn't really go anywhere. https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/20 I then figured it would make sense to