Re: Minuet (music education software) moved to kdereview

2016-02-08 Thread Sandro Andrade
On Sun, Jan 31, 2016 at 8:42 PM, Aleix Pol wrote: > On Mon, Feb 1, 2016 at 12:30 AM, Albert Astals Cid wrote: >> El Tuesday 26 January 2016, a les 10:15:47, Andreas Cord-Landwehr va >> escriure: >>> On Monday 25 January 2016 21:48:27 Albert Astals Cid wrote: >>>

Re: Minuet (music education software) moved to kdereview

2016-02-08 Thread Jeremy Whiting
Sandro, We have a mixture of both in kde-edu. I know kanagram and khangman use their own versioning numbers. If no changes happen between releases we don't bump the version number. If they do we do. I think at some point when it's pretty solid you may want to consider using the KDE Applications

Re: Minuet (music education software) moved to kdereview

2016-02-08 Thread Sandro Andrade
On Mon, Feb 8, 2016 at 2:44 PM, Sandro Andrade wrote: > On Sun, Jan 31, 2016 at 8:42 PM, Aleix Pol wrote: >> On Mon, Feb 1, 2016 at 12:30 AM, Albert Astals Cid wrote: >>> El Tuesday 26 January 2016, a les 10:15:47, Andreas Cord-Landwehr va

Re: Minuet (music education software) moved to kdereview

2016-01-31 Thread Albert Astals Cid
El Tuesday 26 January 2016, a les 10:15:47, Andreas Cord-Landwehr va escriure: > On Monday 25 January 2016 21:48:27 Albert Astals Cid wrote: > > El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va > > escriure: > > > * it looks strange to me that in minuet/cmake/ there are

Re: Minuet (music education software) moved to kdereview

2016-01-31 Thread Aleix Pol
On Mon, Feb 1, 2016 at 12:30 AM, Albert Astals Cid wrote: > El Tuesday 26 January 2016, a les 10:15:47, Andreas Cord-Landwehr va escriure: >> On Monday 25 January 2016 21:48:27 Albert Astals Cid wrote: >> > El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va >> >>

Re: Minuet (music education software) moved to kdereview

2016-01-30 Thread Andreas Cord-Landwehr
On Friday, January 29, 2016 6:53:23 PM CET Sandro Andrade wrote: > Question: Minuet uses TiMidity++ and freepats as run-time > dependencies. Should I improve CMakeLists.txt to detect such > installations (they aren't libraries, maybe some ugly check is > required) as a way to hint packagers to add

Re: Minuet (music education software) moved to kdereview

2016-01-29 Thread Sandro Andrade
On Sun, Jan 24, 2016 at 12:50 PM, Andreas Cord-Landwehr wrote: > Hi Sandro, it is always great when such a cool application lands in KDE Edu. > I just made a first and rough (since I do not have all dependencies yet to > really compile and test it) code review. Hi Andreas,

Re: Minuet (music education software) moved to kdereview

2016-01-29 Thread Sandro Andrade
On Fri, Jan 29, 2016 at 6:47 PM, Sandro Andrade wrote: > On Sun, Jan 24, 2016 at 12:50 PM, Andreas Cord-Landwehr > wrote: >> Hi Sandro, it is always great when such a cool application lands in KDE Edu. >> I just made a first and rough (since I do not

Re: Re: Minuet (music education software) moved to kdereview

2016-01-26 Thread Andreas Cord-Landwehr
On Monday 25 January 2016 21:48:27 Albert Astals Cid wrote: > El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va escriure: > > * it looks strange to me that in minuet/cmake/ there are Config-files for > > the 3rd-party library drumstick. My understanding was that such Config > >

Re: Minuet (music education software) moved to kdereview

2016-01-25 Thread Albert Astals Cid
El Monday 25 January 2016, a les 21:47:34, Albert Astals Cid va escriure: > El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va escriure: > > Hi Sandro, it is always great when such a cool application lands in KDE > > Edu. I just made a first and rough (since I do not have all

Re: Minuet (music education software) moved to kdereview

2016-01-25 Thread Albert Astals Cid
El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va escriure: > Hi Sandro, it is always great when such a cool application lands in KDE Edu. > I just made a first and rough (since I do not have all dependencies yet to > really compile and test it) code review. > > Here a some

Re: Minuet (music education software) moved to kdereview

2016-01-25 Thread Albert Astals Cid
El Sunday 24 January 2016, a les 16:50:18, Andreas Cord-Landwehr va escriure: > * it looks strange to me that in minuet/cmake/ there are Config-files for > the 3rd-party library drumstick. My understanding was that such Config > files should only be shipped with the respective library (maybe

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Andreas Cord-Landwehr
Hi Sandro, it is always great when such a cool application lands in KDE Edu. I just made a first and rough (since I do not have all dependencies yet to really compile and test it) code review. Here a some minors I noticed: * the application does not link against KCrash (which is needed for

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Elvis Angelaccio
2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr : > > also in the main.cpp there should be a call to "KCrash::initialize();" Shouldn't this happen automatically? This is what the documentation at [1] seems to imply, at least. >From a quick search on LXR, it looks like

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Andreas Cord-Landwehr
On Sunday, January 24, 2016 6:47:17 PM CET Elvis Angelaccio wrote: > 2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr : > > also in the main.cpp there should be a call to "KCrash::initialize();" > > Shouldn't this happen automatically? > This is what the documentation at [1]

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Elvis Angelaccio
2016-01-24 18:57 GMT+01:00 Andreas Cord-Landwehr : > On Sunday, January 24, 2016 6:47:17 PM CET Elvis Angelaccio wrote: > > 2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr : > > > also in the main.cpp there should be a call to "KCrash::initialize();" >

Minuet (music education software) moved to kdereview

2016-01-19 Thread Sandro Andrade
Hi there, This is to inform you all that Minuet repository is now in kdereview. The goal is having Minuet joining KDE-Edu in KDE Applications 16.04. Some information about Minuet's goals, features, and technical decisions may be found at: http://sandroandrade.org/a-minuet-for-kde/