Re: New repo in kdereview: KWeather

2022-12-01 Thread Albert Astals Cid
El dimecres, 30 de novembre de 2022, a les 15:58:29 (CET), Devin va escriure: > Should be fixed now, I removed the dialog flag on the window. Confirmed :) > > Thanks, > Devin > > On Tue, Nov 29, 2022 at 10:33 PM Nate Graham wrote: > > This happens on X11 when using QtDialogs for reasons I

Re: New repo in kdereview: KWeather

2022-11-30 Thread Devin
Should be fixed now, I removed the dialog flag on the window. Thanks, Devin On Tue, Nov 29, 2022 at 10:33 PM Nate Graham wrote: > > This happens on X11 when using QtDialogs for reasons I don't understand. > See >

Re: New repo in kdereview: KWeather

2022-11-29 Thread Nate Graham
This happens on X11 when using QtDialogs for reasons I don't understand. See https://invent.kde.org/frameworks/knewstuff/-/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03. Nate On 11/29/22 16:48, Devin wrote: Hmm, I have no idea why the behaviour is different for you, but I get:

Re: New repo in kdereview: KWeather

2022-11-29 Thread Devin
Hmm, I have no idea why the behaviour is different for you, but I get: https://i.imgur.com/CvGD8HS.png If you removed the "Qt.Dialog" flag here: https://invent.kde.org/plasma-mobile/kweather/-/blob/master/src/qml/settings/SettingsWindow.qml#L14, does it still have the issue? Thanks, Devin On

Re: New repo in kdereview: KWeather

2022-11-29 Thread Albert Astals Cid
El dimecres, 30 de novembre de 2022, a les 0:33:39 (CET), Devin va escriure: > > Ok, now that i updated kirigami-addons, the Settings dialog shows, but > > it's uncloseable, any idea why that would be? > That's very strange, it should be showing up as a regular window, does > pressing the close

Re: New repo in kdereview: KWeather

2022-11-29 Thread Devin
> Ok, now that i updated kirigami-addons, the Settings dialog shows, but it's > uncloseable, any idea why that would be? That's very strange, it should be showing up as a regular window, does pressing the close button on the window decoration not work? Thanks, Devin On Tue, Nov 29, 2022 at

Re: New repo in kdereview: KWeather

2022-11-29 Thread Albert Astals Cid
El dilluns, 28 de novembre de 2022, a les 17:15:57 (CET), Albert Astals Cid va escriure: > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va escriure: > > > There's potentially overlapping text. > > > > I have fixed text wrapping in the weather delegates so it should wrap > >

Re: New repo in kdereview: KWeather

2022-11-28 Thread Devin
> You've been told that you need to increase your minimum dependency in another > email, i'll do it again. > > Increase your required version of kirigami addons so that it matches reality. I apologize for being confused, I was wondering how I was supposed to bump a runtime QML dependency

Re: New repo in kdereview: KWeather

2022-11-28 Thread Devin
Is there some way I can do this at runtime? kirigami-addons is used here as a QML API. Thanks, Devin On Mon, Nov 28, 2022 at 12:17 PM Ingo Klöcker wrote: > > On Montag, 28. November 2022 17:53:59 CET Devin wrote: > > > FWIW i can't open settings anymore > > > > Make sure you have the latest

Re: New repo in kdereview: KWeather

2022-11-28 Thread Albert Astals Cid
El dilluns, 28 de novembre de 2022, a les 17:53:59 (CET), Devin va escriure: > > FWIW i can't open settings anymore > > Make sure you have the latest kirigami-addons built (from master). Depending on an unreleased version of a dependency is not acceptable if you want to release your application

Re: New repo in kdereview: KWeather

2022-11-28 Thread Ingo Klöcker
On Montag, 28. November 2022 17:53:59 CET Devin wrote: > > FWIW i can't open settings anymore > > Make sure you have the latest kirigami-addons built (from master). I have read "use the latest kirigami-addons" many times in the last few weeks. Isn't it possible to add a version check to detect

Re: New repo in kdereview: KWeather

2022-11-28 Thread Devin
> FWIW i can't open settings anymore Make sure you have the latest kirigami-addons built (from master). Thanks, Devin On Mon, Nov 28, 2022 at 11:15 AM Albert Astals Cid wrote: > > El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va escriure: > > > There's potentially

Re: New repo in kdereview: KWeather

2022-11-28 Thread Albert Astals Cid
El divendres, 25 de novembre de 2022, a les 4:46:40 (CET), Devin va escriure: > > There's potentially overlapping text. > > I have fixed text wrapping in the weather delegates so it should wrap > properly now. > > > Here settingsModel.forecastStyle is not i18n'ed > > I have fixed it now (it

Re: New repo in kdereview: KWeather

2022-11-24 Thread Devin
> There's potentially overlapping text. I have fixed text wrapping in the weather delegates so it should wrap properly now. > Here settingsModel.forecastStyle is not i18n'ed I have fixed it now (it converts to i18n'd dedicated strings in the QML) On Mon, Nov 14, 2022 at 5:10 PM Albert Astals

Re: New repo in kdereview: KWeather

2022-11-14 Thread Nate Graham
Really great app. I have just a few minor UX comments, in order of how strongly I feel about them: The main page has no scrollbars, so it's not obvious that the view is scrollable, especially because with various window sizes, nothing looks visibly cut off on the bottom to suggest

Re: New repo in kdereview: KWeather

2022-11-14 Thread Albert Astals Cid
El dimecres, 9 de novembre de 2022, a les 23:00:13 (CET), Devin va escriure: > Hi everyone, > > I would like to put kweather through kdereview: > > https://invent.kde.org/plasma-mobile/kweather > > KWeather is an application that can give simple weather information > for different weather

Re: New repo in kdereview: KWeather

2022-11-12 Thread Carl Schwan
Hi, You are missing kirigami-addons and yes this should be marked in the cmakelists.txt file. Cheers, Carl Original Message On Nov 12, 2022, 20:14, Jeremy Whiting wrote: > Looks like it's got a runtime dependency on kirigami (Maybe that's expected > for plasma-mobile, not

Re: New repo in kdereview: KWeather

2022-11-12 Thread Jeremy Whiting
Looks like it's got a runtime dependency on kirigami (Maybe that's expected for plasma-mobile, not sure) Built it on laptop and got this from cmake: cmake .. -- The C compiler identification is GNU 12.2.0 -- The CXX compiler identification is GNU 12.2.0 -- Detecting C compiler ABI info --

Re: New repo in kdereview: KWeather

2022-11-09 Thread Devin
> Only nitpick I found as a user was that it's a bit weird that Settings -> > About changes the main window instead of showing about data in the little > settings window. I would suggest making About be one of the buttons on the > main window, or showing the about data in the settings window.

Re: New repo in kdereview: KWeather

2022-11-09 Thread Jeremy Whiting
After installing kirigami-addons it runs fine, adding my location went smooth, etc. Only nitpick I found as a user was that it's a bit weird that Settings -> About changes the main window instead of showing about data in the little settings window. I would suggest making About be one of the

Re: New repo in kdereview: KWeather

2022-11-09 Thread Devin
Hi Jeremy, Looks like I forgot to add a CMake check for Kirigami Addons. It has been added now. KWeather has a runtime dependency on Kirigami Addons as well, not just Kirigami. Thanks, Devin On Wed, Nov 9, 2022 at 5:31 PM Jeremy Whiting wrote: > > Looks like it's got a runtime dependency on

New repo in kdereview: KWeather

2022-11-09 Thread Devin
Hi everyone, I would like to put kweather through kdereview: https://invent.kde.org/plasma-mobile/kweather KWeather is an application that can give simple weather information for different weather locations. Please note that KWeatherCore (the library the app depends on) has already passed