Re: KScreenGenie moved to KDE Review

2015-07-13 Thread Albert Astals Cid
El Dimarts, 7 de juliol de 2015, a les 21:41:36, Boudhayan Gupta va escriure: On 4 July 2015 at 21:09, Boudhayan Gupta m...@baloneygeek.com wrote: Hi Burkhard, Some minor nitpicking: Docbook: Afaik Alt+Space is default kf5 shortcut for KRunner, wrong in docbook Shortcut Ctrl+C and

Re: KScreenGenie moved to KDE Review

2015-07-13 Thread Boudhayan Gupta
Is there any chance KSG can make it into kdegraphics in time for 15.08? The freeze is pretty soon, and I don't plan on adding any new features for this cycle. I would personally feel safer if you did a more limited release this cycle and joined KDE Applications for 15.12. Anyone else?

Re: KScreenGenie moved to KDE Review

2015-07-07 Thread Boudhayan Gupta
On 4 July 2015 at 21:09, Boudhayan Gupta m...@baloneygeek.com wrote: Hi Burkhard, Some minor nitpicking: Docbook: Afaik Alt+Space is default kf5 shortcut for KRunner, wrong in docbook Shortcut Ctrl+C and Esc missing in docbook Resizable Window, where resizing the window ends up resizing the

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Boudhayan Gupta
On 4 July 2015 at 14:56, Thomas Lübking thomas.luebk...@gmail.com wrote: Window under mouse actually shoots the active window what makes it ipossible to shoot eg. floating docks (*unrelated* to hiding inactive utility windows) or mainwindows with a modal transient (ie. kwrite while there's a

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Boudhayan Gupta
On 4 July 2015 at 15:15, Burkhard Lück lu...@hube-lueck.de wrote: Am Samstag, 4. Juli 2015, 15:00:48 schrieb Boudhayan Gupta: This has been fixed in the latest commit I did last night. There's also a new mode which allows you to shoot Transients along with the parent window in the same image.

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Alexander Potashev
2015-07-04 12:43 GMT+03:00 Boudhayan Gupta m...@baloneygeek.com: You've gone ahead and moved all the includes from the header file to the .cpp file? I'm going to revert that commit, since the decision to keep all the #includes in the header is a coding style decision I consciously made. I know

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Burkhard Lück
Am Donnerstag, 2. Juli 2015, 21:47:16 schrieb Boudhayan Gupta: Hi, I've fixed up the UI as per the above mail thread, and pushed to master. Download and test! Copy to clipboard has UI feedback now with a KMessageBox, On 29 June 2015 at 19:51, Boudhayan Gupta m...@baloneygeek.com wrote:

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Burkhard Lück
Am Samstag, 4. Juli 2015, 15:00:48 schrieb Boudhayan Gupta: This has been fixed in the latest commit I did last night. There's also a new mode which allows you to shoot Transients along with the parent window in the same image. Is this already mentioned in the docbook? -- Burkhard Lück

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Thomas Lübking
On Donnerstag, 2. Juli 2015 18:17:16 CEST, Boudhayan Gupta wrote: Hi, I've fixed up the UI as per the above mail thread, and pushed to master. Download and test! Window under mouse actually shoots the active window what makes it ipossible to shoot eg. floating docks (*unrelated* to hiding

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Boudhayan Gupta
On 4 July 2015 at 05:30, Alexander Potashev aspotas...@gmail.com wrote: 2015-07-04 0:53 GMT+03:00 Albert Astals Cid aa...@kde.org: For some reason /usr/include/x86_64-linux-gnu/qt5/QtX11Extras is not in the include path. Any idea why? Fixed in

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Boudhayan Gupta
Hi Alexander, Projects use different coding styles because each has its pros and cons. But regarding this #include thing the solution recommended in the links below is much more advantageous than what you decided to do. [1] http://programmers.stackexchange.com/a/262020 [2]

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Boudhayan Gupta
Hi Burkhard, Some minor nitpicking: Docbook: Afaik Alt+Space is default kf5 shortcut for KRunner, wrong in docbook Shortcut Ctrl+C and Esc missing in docbook Resizable Window, where resizing the window ends up resizing the screenshot in it missing in docbook The docbook is very

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Alexander Potashev
2015-07-04 13:11 GMT+03:00 Boudhayan Gupta m...@baloneygeek.com: [1] http://programmers.stackexchange.com/a/262020 [2] http://stackoverflow.com/a/15420950 I'd seen both of these topics before. I'd obviously use minimal headers in libraries and other projects where the headers could be used

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Boudhayan Gupta
Hi Alexander, It doesn't seem right to apply different rules to headers that are exported and not exported. Are you going to rewrite the includes if/when the class ImageGrabber becomes a public library? (E.g. when someone wants to incorporate a screen grabber into his application.) Nothing

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Alexander Potashev
Boudhayan, Please find my comment below. 2015-07-04 14:29 GMT+03:00 Boudhayan Gupta m...@baloneygeek.com: You said I can see exactly which components a single cpp file depends on my looking at the headers. If you follow the recommendation in the links [1,2], all the dependent components will

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Boudhayan Gupta
Hi Alexander, No, some of them stay over in the header file. Everything in one place, for a small application such as this, which is not a public library, takes precedence over minorly increased build times. Again, if you follow the links [1,2], then Foo.cpp should have #include QString

Re: KScreenGenie moved to KDE Review

2015-07-03 Thread Alexander Potashev
2015-07-04 0:53 GMT+03:00 Albert Astals Cid aa...@kde.org: For some reason /usr/include/x86_64-linux-gnu/qt5/QtX11Extras is not in the include path. Any idea why? Fixed in http://commits.kde.org/kscreengenie/ace898e614d612a84ee12f22562d6d7365ee24bc Because when XCB_FOUND is not set,

Re: KScreenGenie moved to KDE Review

2015-07-02 Thread Boudhayan Gupta
Hi, I've fixed up the UI as per the above mail thread, and pushed to master. Download and test! Copy to clipboard has UI feedback now with a KMessageBox, On 29 June 2015 at 19:51, Boudhayan Gupta m...@baloneygeek.com wrote: Hi Thomas, On 29 June 2015 at 19:30, Thomas Lübking

Re: KScreenGenie moved to KDE Review

2015-06-29 Thread Thomas Lübking
On Montag, 29. Juni 2015 11:58:29 CEST, Boudhayan Gupta wrote: Hi Thomas, It's a standard QDialogButtonBox. I haven't set the button ordering manually at all. Maybe it's a QDialogButtonBox bug then. It's because eg. you use the Apply role for Save Exit (would rather be Ok role) and Discard

Re: KScreenGenie moved to KDE Review

2015-06-29 Thread Boudhayan Gupta
Hi Thomas, On 29 June 2015 at 19:30, Thomas Lübking thomas.luebk...@gmail.com wrote: It's because eg. you use the Apply role for Save Exit (would rather be Ok role) and Discard for Discard, while the latter actually acts as Cancel (reject, not reset and exit - there's nothing to reset in the

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Boudhayan Gupta
On 28 June 2015 at 15:06, Martin Koller kol...@aon.at wrote: It is now at Send To - Clipboard. Wow, that's mega ugly. Another click for the (my) most common action used. In ksnapshot Send To is very inconvenient, since it seems to load all kipi plugins and is awfully slow (it takes some

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Boudhayan Gupta
On 28 Jun 2015 14:28, Martin Koller kol...@aon.at wrote: On Thursday 18 June 2015 15:03:27 Boudhayan Gupta wrote: Here's an Imgur album with some more screenshots, including how Rectangle Selection works: http://imgur.com/a/1peZa I miss the copy button to be able to copy the captured

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Martin Koller
On Thursday 18 June 2015 15:03:27 Boudhayan Gupta wrote: Here's an Imgur album with some more screenshots, including how Rectangle Selection works: http://imgur.com/a/1peZa I miss the copy button to be able to copy the captured image to the clipboard -- Best regards/Schöne Grüße Martin

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Martin Gräßlin
On Tuesday 16 June 2015 02:45:56 Boudhayan Gupta wrote: The other thing I'd like to mention here is that there was talk on IRC and the kde-community list a few months back that if KScreenGenie does end up passing review and replacing KSnapshot, that it should take the KSnapshot name and just

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Hugo Pereira Da Costa
On 06/28/2015 06:40 PM, Hugo Pereira Da Costa wrote: On 06/28/2015 10:58 AM, Martin Koller wrote: On Thursday 18 June 2015 15:03:27 Boudhayan Gupta wrote: Here's an Imgur album with some more screenshots, including how Rectangle Selection works: http://imgur.com/a/1peZa I miss the copy

Re: Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Martin Gräßlin
On Sunday 28 June 2015 16:37:31 you wrote: 2) I'm home for the holidays and practically free with nothing else to do until the first week of August. Even after college starts again, the workload isn't so much that I'm unable to fix bugs within hours or at most 1-2 days (in rare circumstances)

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Hugo Pereira Da Costa
On 06/28/2015 10:58 AM, Martin Koller wrote: On Thursday 18 June 2015 15:03:27 Boudhayan Gupta wrote: Here's an Imgur album with some more screenshots, including how Rectangle Selection works: http://imgur.com/a/1peZa I miss the copy button to be able to copy the captured image to the

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Boudhayan Gupta
On 28 June 2015 at 14:40, Martin Gräßlin mgraess...@kde.org wrote: On Tuesday 16 June 2015 02:45:56 Boudhayan Gupta wrote: The other thing I'd like to mention here is that there was talk on IRC and the kde-community list a few months back that if KScreenGenie does end up passing review and

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Eike Hein
On 06/28/2015 11:10 AM, Martin Gräßlin wrote: In opposite KSnapshot is a very mature application with a decade of development behind it. It's also a rather stagnant one, and a new developer with the desire to improve upon the status quo is a high-value community asset much in the same way as

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Boudhayan Gupta
Hi, Two regressions that I've spotted running with latest KSG from master branch: 1/ as far as I can tell, the window is non resizable. KSnapshot is, and resizing the window ends up resizing the screenshot in it, which I find really useful. I'll take a look at this. Yes, I had made the

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Mark Gaiser
On Sun, Jun 28, 2015 at 7:27 PM, Eike Hein h...@kde.org wrote: On 06/28/2015 11:10 AM, Martin Gräßlin wrote: In opposite KSnapshot is a very mature application with a decade of development behind it. It's also a rather stagnant one, and a new developer with the desire to improve upon

Re: Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Boudhayan Gupta
On 28 June 2015 at 21:17, Martin Gräßlin mgraess...@kde.org wrote: This worries me a little bit. Not the fact of how much time is available, but the fact that you do a rather short term thinking. Let's put it simple: there won't be any bug reports prior to October when the first large distros

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Thomas Lübking
Did a functional test only. a) The button role assignment seems wrong (you tried to arrange buttons in a certain order that suits either the KDE or windows order? They end up totally weird other orders eg. GTK or OSX) b) Buttons 1. While I like the Save Exit idea, it leaves uncertainity

Re: KScreenGenie moved to KDE Review

2015-06-18 Thread Boudhayan Gupta
On 18 June 2015 at 09:51, Yuri Chornoivan yurc...@ukr.net wrote: Perhaps you could point us all to some screenshots? One requirement for passing review and an eventual replacement of ksnapshot should be a successful review by our usability crew, maybe it can also be made prettier with some

Re: KScreenGenie moved to KDE Review

2015-06-18 Thread Yuri Chornoivan
написане Thu, 18 Jun 2015 03:40:48 +0300, Sebastian Kügler se...@kde.org: On Tuesday, June 16, 2015 02:45:56 Boudhayan Gupta wrote: The other thing I'd like to mention here is that there was talk on IRC and the kde-community list a few months back that if KScreenGenie does end up passing

Re: KScreenGenie moved to KDE Review

2015-06-17 Thread Sebastian Kügler
On Tuesday, June 16, 2015 02:45:56 Boudhayan Gupta wrote: The other thing I'd like to mention here is that there was talk on IRC and the kde-community list a few months back that if KScreenGenie does end up passing review and replacing KSnapshot, that it should take the KSnapshot name and just

Re: KScreenGenie moved to KDE Review

2015-06-16 Thread Richard Moore
On 15 June 2015 at 22:15, Boudhayan Gupta m...@baloneygeek.com wrote: The other thing I'd like to mention here is that there was talk on IRC and the kde-community list a few months back that if KScreenGenie does end up passing review and replacing KSnapshot, that it should take the KSnapshot