Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-12-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Dec. 14, 2013, 11:33 a.m.) Status -- This change has been

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-12-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review45673 --- This review has been submitted with commit

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-12-12 Thread Ben Cooksley
On Nov. 29, 2013, 7:32 p.m., Ben Cooksley wrote: Patch looks fine to me, sucks a bit that the names have to be hardcoded for certain lists but not much can be done there if that is what the applications do... Burkhard Lück wrote: Patch looks fine to me = Ship It! ? I was hoping

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-12-10 Thread Burkhard Lück
On Nov. 29, 2013, 7:32 p.m., Ben Cooksley wrote: Patch looks fine to me, sucks a bit that the names have to be hardcoded for certain lists but not much can be done there if that is what the applications do... Patch looks fine to me = Ship It! ? - Burkhard

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-29 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 29, 2013, 12:37 p.m.) Review request for Documentation, KDE

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-29 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44837 --- Patch looks fine to me, sucks a bit that the names have to be

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-28 Thread Burkhard Lück
On Nov. 22, 2013, 7:05 a.m., Ben Cooksley wrote: khelpcenter/plugintraverser.cpp, line 95 http://git.reviewboard.kde.org/r/111851/diff/1/?file=176031#file176031line95 Do you intend on modifying the control modules used by Dolphin and Konqueror here to fit this? That sounds like

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-28 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 28, 2013, 8:36 p.m.) Review request for Documentation, KDE

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-28 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44734 --- In theory I have a possible solution using the existing

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-28 Thread David Faure
On Nov. 28, 2013, 8:42 p.m., Burkhard Lück wrote: In theory I have a possible solution using the existing X-KDE-PluginKeyword in the desktop files, so no changes outside khelpcenter would be required. But in contrary to the api documentation this does not work or I do wrong: $

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Nov. 21, 2013, 11:50 a.m.) Review request for Documentation, KDE

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review44080 --- kcmshell/main.cpp

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-11-17 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review43855 --- Please review - Burkhard Lück On Sept. 3, 2013, 12:38 p.m.,

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-09-03 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/ --- (Updated Sept. 3, 2013, 12:38 p.m.) Review request for Documentation and

Re: Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

2013-08-03 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111851/#review37027 --- I don't see this being important enough to warrant new strings