Re: Review Request 113969: Do not assume every items have the same height

2014-05-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/#review57618 --- This review has been submitted with commit

Re: Review Request 113969: Do not assume every items have the same height

2014-05-08 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/ --- (Updated May 8, 2014, 10:45 p.m.) Status -- This change has been

Re: Review Request 113969: Do not assume every items have the same height

2014-04-22 Thread Yichao Yu
On April 6, 2014, 7:48 a.m., David Faure wrote: kdeui/itemviews/kcategorizedview.cpp, line 795 https://git.reviewboard.kde.org/r/113969/diff/4/?file=215105#file215105line795 Coding style comment: some code paths use break (which results in return QModelIndex() at the end) and

Re: Review Request 113969: Do not assume every items have the same height

2014-04-22 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/ --- (Updated April 22, 2014, 6:13 a.m.) Review request for kdelibs, David

Re: Review Request 113969: Do not assume every items have the same height

2014-04-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/#review55062 --- I don't know this code so unfortunately I can't really

Re: Review Request 113969: Do not assume every items have the same height

2013-12-09 Thread Yichao Yu
On Nov. 20, 2013, 5:27 p.m., Christoph Feck wrote: I love people who report bugs, and one year later come up with a patch :P Anyway, nice analysis, and this probably also fixes bug 290971, but have not tested it yet. Yichao Yu wrote: Unfortunately I think I can still reproduce

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 12:24 p.m.) Review request for kdelibs, David

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 4:46 p.m.) Review request for kdelibs, David

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/ --- (Updated Nov. 20, 2013, 4:47 p.m.) Review request for kdelibs, David

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113969/#review44071 --- I love people who report bugs, and one year later come up with

Re: Review Request 113969: Do not assume every items have the same height

2013-11-20 Thread Yichao Yu
On Nov. 20, 2013, 5:27 p.m., Christoph Feck wrote: I love people who report bugs, and one year later come up with a patch :P Anyway, nice analysis, and this probably also fixes bug 290971, but have not tested it yet. Unfortunately I think I can still reproduce those problems. (I